#1086 Python2 to Python3 convert process
Closed by thunderbirdtr. Opened by thunderbirdtr.
Unknown source main

Download 1086.patch
  • build.py

python syntax errors fixed (such as print)
line 150 : translation part opened with "rb"
line 243 : template.generate "encoding removed"

  • buildconf.py

python syntax errors fixed (such as print)
lang_regex list(zip()) fixed

  • construct-translatins.py

rename ConfigParser to configparser
readfp to "read_file" (new way)

  • rss.py

python syntax errors fixed

Tested websites;

labs.fedoraproject.org
arm.fedoraproject.org
boot.fedoraproject.org
mirrors.fedoraproject.org (always working)
flock.fedoraproject.org
fedorapeople.org (not python releated because it just a shell script file)
fedoracommunity.org
budget.fedoraproject.org
spins.fedoraproject.org

1 new commit added

  • time library removed

This merge require : https://pagure.io/fedora-websites/pull-request/1084 for new py3 package dependencies.

CC @t0xic0der @codeblock @asamalik

LGTM.

I have been there with @thunderbirdtr with his screen shared when the changes were made and tested, so I am certain that these do work.

Metadata Update from @t0xic0der:
- Request assigned

rebased onto 9ee67ed2b7e1cc27bbbc85f32d20c25f7280e61c

@t0xic0der merge conflict solved. Please re-check.

Hi Onuralp,

I am doing some checks again from my end and I have also asked @lilyx to
one test run as well. :)

On Fri, Jun 18, 2021 at 11:40 AM Onuralp SEZER pagure@pagure.io wrote:

thunderbirdtr commented on the pull-request: Python2 to Python3 convert process that you are following:
@t0xic0der merge conflict solved. Please re-check.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/pull-request/1086

--
Thanks and regards,
Akashdeep Dhar
t0xic0der@fedoraproject.org

Hi @thunderbirdtr,

Could you please amend your recent commit https://pagure.io/fork/thunderbirdtr/fedora-websites/c/9ee67ed2b7e1cc27bbbc85f32d20c25f7280e61c to have a more correct message and then make a force-push?

Thanks, @sayanchowdhury for marking this out.

Hi @thunderbirdtr,

The fedoraproject.org directory would take some looking into.

Here's an error log.

[root@7a69537ccc22 fedoraproject.org]# make es testfg
python3 /data/fedora-websites/fedoraproject.org/../build.d/build.py -o out -s static -b /
Traceback (most recent call last):
  File "/data/fedora-websites/fedoraproject.org/../build.d/build.py", line 49, in <module>
    from rss import *
  File "build/rss.py", line 35
    print 'ERROR: ' + str(main_feed['bozo_exception'])
          ^
SyntaxError: invalid syntax
make: *** [../Makefile.in:34: static] Error 1

I think the last merge in this PR goes sideways, and I don't see anything related to the py3 migration anymore.

I went ahead and rebase everything in a new branch to make it simpler.
https://pagure.io/fork/darknao/fedora-websites/commits/rebase_py3

The last 5 commits in my fork are the relevant ones.
Additionally, I've included a fix for my last merge (#1081) to be py3 compatible, and fixed the fedoraproject.org build.
Note about that last one: fedoraproject.org doesn't really need to be built anymore, as it is now a simple redirect to getfedora.org. It can be probably be removed from this repo.

Finally, you'll find an update of the Dockerfile (same as #1084) with an additional package (python3-langtable) which is a requirements from #1081.

Build have been tested on following websites:
labs.fedoraproject.org
arm.fedoraproject.org
alt.fedoraproject.org
flocktofedora.org
spins.fedoraproject.org
fedoracommunity.org
start.fedoraproject.org
fedoraproject.org

You probably already know this, but you should be very careful about merging this PR on master.
The production build system is using an old RHEL7 vm that doesn't meet any of your python3 requirements. This means the build will break as soon as this PR is merged, unless you are already in sync with someone from infra for that. In that case, please disregard my comment.
(I can also help on this topic, if needed ;) )

Metadata Update from @jflory7:
- Pull-request tagged with: tools

As @jflory7 suggested here https://pagure.io/fedora-websites/pull-request/1084#comment-160625, would we want to include the updated Dockerfile in this same PR so as to simplify two related changes into one PR?

CC @thunderbirdtr @darknao

The websites build pipeline is now hosted on Openshift, and can be safely upgraded to fedora:36 / python3.

Pull-Request has been closed by thunderbirdtr

This change won't be require since new website is coming.

Metadata