#1084 Updated base container tag and package versions
Closed 21 days ago by jflory7. Opened 5 months ago by t0xic0der.
Unknown source version-bump-dockerfile  into  master

file modified
+4 -4
@@ -1,10 +1,10 @@

- FROM fedora:30

+ FROM fedora:34

  MAINTAINER Rick Elrod <relrod@redhat.com>

  

  WORKDIR /opt/oldrepo/

  

- RUN  dnf install -y git gettext python-genshi python-lxml python-setuptools \

-      python-dateutil python-dogpile-cache babel python-feedparser fedfind \

-      python-requests python2-babel findutils make httpd

+ RUN  dnf install -y git gettext python3-genshi python3-lxml python3-setuptools \

+      python3-dateutil python3-dogpile-cache babel python3-feedparser fedfind \

+      python3-requests python3-babel findutils make httpd

  

  EXPOSE 5000

Signed-off-by: Akashdeep Dhar akashdeep.dhar@gmail.com

DRAFT : Build scripts are yet to be upgraded so PLEASE DO NOT MERGE

Closes #1009

I have preferred to use fedora:34 instead of fedora:latest as the base image because, with the latter, I would be blindly assuming that the packages mentioned under them would be maintained for future releases as well - which might or might not be true.

CC @thunderbirdtr

Shouldn't we upgrade the build scripts to python3 first ?
The current version of this Dockerfile seems to be the only reliable way to build and test websites.

@darknao, I forgot to mention the draft status of the PR as I will be working alongside @thunderbirdtr on this one - but yes, we are working on front-porting the build scripts too.

I agree with @t0xic0der about using fedora:34 tag instead of latest because when we get f35 It could create unexpected error, so it is fine to stay on f34 tag. Secondly yes we also should update everything to py3 compatible and delete old py2 codes as well.

I front-ported some of the modules relevant to alt.fedoraproject.org and getfedora.org - so when I run make en test in them, I get the following error and I am not sure if it has something to do with the code or with the translation files.

[t0xic0der@fedorable alt.fedoraproject.org]$ make en test
python3 /home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py -o out -s static -b /
python3 /home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py -o out -i data/content -l en -p po -b /
Traceback (most recent call last):
  File "/home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py", line 307, in <module>
    main()
  File "/home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py", line 304, in main
    process(args)
  File "/home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py", line 134, in process
    process_dir(dirpath, filenames)
  File "/home/t0xic0der/Projects/fedora-websites-2/alt.fedoraproject.org/../build.d/build.py", line 150, in process_dir
    translations = GNUTranslations(open(os.path.join(options.podir, options.lang + '.mo')))
  File "/usr/lib64/python3.9/gettext.py", line 261, in __init__
    self._parse(fp)
  File "/usr/lib64/python3.9/gettext.py", line 384, in _parse
    buf = fp.read()
  File "/usr/lib64/python3.9/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xde in position 0: invalid continuation byte
make: *** [Makefile:4: en] Error 1

Metadata Update from @t0xic0der:
- Request assigned

5 months ago

Hi, I noticed this Pull Request was mentioned as a blocker for #1086, but there are conflicts and the source remote for this PR is missing. Should we close this Pull Request in favor of a new change, or bundling it into #1086 instead?

Metadata Update from @jflory7:
- Pull-request tagged with: tools

24 days ago

@jflory7, that would probably the right thing to do in order to simplify the relevant changes into one PR. @darknao, @thunderbirdtr - what do you folks recommend?

Given this Pull Request's source remote is gone, I don't think there is a way for us to close this PR by merging. I am going to close it now, and we can push forward this conversation in #1086.

Pull-Request has been closed by jflory7

21 days ago
Metadata