In the old version of golang-github-pkg-errors, there was a typo, and glide.yaml was listed twice in the sources. This meant that glide.lock was never copied to the source directory.
glide.yaml
glide.lock
When %goinstall glide.yaml glide.lock was called later, it created a glide.lock directory. Now that I'm trying to fix it, it causes an upgrade error since rpm can't handle a directory->file change. So now I need to go throw in a scriptlet to fix the directory.
%goinstall glide.yaml glide.lock
%goinstall should not accept an explicit path argument that does not exist, and should fail the build. If it really needs to be able to create arbitrary directories like that, it should be behind an explicit flag (like install -d is).
%goinstall
install -d
Yes goinstall error checking should be improved (even though the target will be modules soonish that should hopefully remove the need for custom install hacks)
(BTW did you check what happens with the current macro version? This part has been refactored for more robustness, even though this is definitely a case I didn't check so if it's fixed it's fixed as a side effect of something else ;))
Ok I've checked the current code and the problem also exists here.
I have a fix, will commit it once I'm somewhere that allows ssh access to pagure (since pagure does not allow https commits)
And the fix is now in rawhide, with go-rpm-macros 3.0.8
Metadata Update from @nim: - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.