#46 %gobuildflags missing double quotation marks
Closed a month ago by gotmax23. Opened 2 years ago by hruskape.

It seems that commit https://pagure.io/go-rpm-macros/c/359d80bbfe7f0490fc51c43af8d986863516c5bb?branch=master breaking %gobuildflags usage in spec file.

Getting error, as double quotation marks are removed.
Specfile section
unset LDFLAGS
%make_build GOBUILDFLAGS="%{gobuildflags}"

Error:
+ /usr/bin/make -O -j16 V=1 VERBOSE=1 'GOBUILDFLAGS=-buildmode pie -compiler gc -tags=rpm_crashtraceback' ' -ldflags ' -B 0x3433f3bcad171c4e7f8f736da295a9fac8289b8c -compressdwarf=false -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -a -v -x'
/usr/bin/make: invalid option -- 'c'
/usr/bin/make: invalid option -- 'x'
Usage: make [options] [target] ...


This should be covered by the the new %{gobuildflags_shescaped} macro.

Metadata Update from @gotmax23:
- Issue status updated to: Closed (was: Open)

a month ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #62 Merged 2 months ago