Side bar does not scroll on large screen dimensions (making it impossible to click on other pages)
On my screen, when the side bar flows off-screen, I am unable to scroll down further to select other pages. This is a critical bug because it prevents others from fully utilizing the application and accessing all pages.
This bug should be fixed before deploying to the production environment (#111).
<img alt="Screenshot of fixed menu sidebar (no ability to scroll down and select other pages)" src="/fedora-commops/fedora-happiness-packets/issue/raw/files/88a2a159aaadd4d9561befe2de1bd905ca3e9d2ec8c8064991e9b36100439d03-Screenshot_2019-03-19_Open-source_Happiness_Packets3.png" />
Originally I remember the text size being smaller, but at some point, this change must have made it into the code and I missed it. :disappointed: I'm not sure if the better option is to make the text smaller (so it will fit on laptop/monitor screens) or if it is better to make it scrollable. Or perhaps the answer is both. Personally the links feel really big to me on my laptop, so I would prefer to see the font size reduced.
This area is not my strength, so this ticket is definitely open for interpretation on how to fix it. Before assigning this ticket, someone should give a couple of sentences about what they think the problem is and how it can be fixed.
End user is able to open all pages regardless of what device is used
Hi @jflory7 I was able to reproduce the bug in my large screen like this: <img alt="Screen_Shot_2019-03-19_at_15.32.19.png" src="/fedora-commops/fedora-happiness-packets/issue/raw/files/e58f1f4727e3e811a57abde577e06639df3f32c75bf08627129da8507b8e87ac-Screen_Shot_2019-03-19_at_15.32.19.png" />
And from what I have seen, I think we can reduce the size of the body text so that users can scroll down and see all remaining options. I have tried editing it in my Dev Tools and the sidebar looks better, except that then we will have to fix maybe the padding or margin of the text divs in all pages as well to scale the text better. For example here:
<img alt="Screen_Shot_2019-03-19_at_15.31.41.png" src="/fedora-commops/fedora-happiness-packets/issue/raw/files/73f5854ab69d28560895a06bb447b7328ee71f218482fcc7bbcbfac81623bcc3-Screen_Shot_2019-03-19_at_15.31.41.png" />
Would love to know about your thoughts on this!
And from what I have seen, I think we can reduce the size of the body text so that users can scroll down and see all remaining options. I have tried editing it in my Dev Tools and the sidebar looks better, except that then we will have to fix maybe the padding or margin of the text divs in all pages as well to scale the text better. For example here: Would love to know about your thoughts on this!
The approach sounds right. I think it's also a valid use case to expect a really large screen at some point. I was thinking specifically of a big projector screen at something like Flock if someone is presenting about the project. It might help to experiment with a variety of dimensions and devices.
And from what I have seen, I think we can reduce the size of the body text so that users can scroll down and see all remaining options. I have tried editing it in my Dev Tools and the sidebar looks better, except that then we will have to fix maybe the padding or margin of the text divs in all pages as well to scale the text better. For example here: Would love to know about your thoughts on this! The approach sounds right. I think it's also a valid use case to expect a really large screen at some point. I was thinking specifically of a big projector screen at something like Flock if someone is presenting about the project. It might help to experiment with a variety of dimensions and devices.
Definitely agree with you! If no one is taking up this issue, I would love to do it! I would like to try my suggested approach into solving this ticket, if you allow, since I think this ticket and the #134 one that I'm still working on improving the responsive footer design are related to each other.
@anhpham Can I please ask you to hold on for some time. Because If you look at the discussions on #134 I have suggested a sub-menu redesign. Once implemented will possibly take care of this issue.
@jflory7 I think we can get back to this once the sub-menu is implemented.
Thoughts..???
@anhpham Can I please ask you to hold on for some time. Because If you look at the discussions on #134 I have suggested a sub-menu redesign. Once implemented will possibly take care of this issue. @jflory7 I think we can get back to this once the sub-menu is implemented. Thoughts..???
Yes sorry! I just got back to re-reading #134 discussion again and saw your suggestion. For sure, I think sub-menu redesign is a great possible solution to this too. 👍👍
@anhpham Can I please ask you to hold on for some time. Because If you look at the discussions on #134 I have suggested a sub-menu redesign. Once implemented will possibly take care of this issue. @jflory7 I think we can get back to this once the sub-menu is implemented.
Hi @phoenixabhishek, how long will the sub-menu redesign take? Since the Outreachy application period ends week, I want to make sure others have a fair shot to work on something. I don't currently see this ticket blocked by the sub-menu redesign.
@jflory7 okk sure.
@anhpham you can start working on this :smile: :smile: :smile: :smile: :smile:
@jflory7 okk sure. @anhpham you can start working on this 😄 😄 😄 😄 😄
@phoenixabhishek sure! Thanks for the insight! @jflory7 I will start working on it if you allow 😄
@jflory7 I will start working on it if you allow 😄
Sure! Feel free to start working on this. :thumbsup:
Metadata Update from @jflory7: - Issue untagged with: help wanted - Issue assigned to anhpham
With my testing after merging #206, this should be fixed. Closing as complete.
Thanks for working on this, @anhpham! :smile:
Metadata Update from @jflory7: - Issue close_status updated to: complete - Issue status updated to: Closed (was: Open)
Metadata Update from @jflory7: - Issue set to the milestone: Summer Coding 2019: community bonding
Login to comment on this ticket.