Replace old artwork assets with new artwork assets
Since the artwork directory is no longer used in our project as it houses the images and logos used by the upstream, it's only appropriate to remove that directory from our project. It will lessen our project directory size by 2.6 MB
No artwork directory available in the project.
Hey @shraddhaag how about installing the dependency django-webpack-loader which would remove such unused dependency or files? (Just an idea)
@alishapapun Hi! Thank you for sharing this. I learnt something new today! I haven't used django-webpack-loader but from what I read it's mainly used to handle a project that has heavy JS and/or it's frameworks' dependency. Since our project doesn't have that I think it might not be best suited for this project.
django-webpack-loader
Welcome @shraddhaag. I agree with the point that this project's less framework's dependency and less JS as well. But don't you think adding such a dependency would be helpful for future (assuming the code base to me larger that this), since our project has lots of contributors, getting a file that's not required is common. Manually checking for unused dependency and unused files require lots of debugging and the process can be frustrating. Adding such a dependency will always be helpful. Would love to hear your point of view @jflory7 and your also @shraddhaag.
Metadata Update from @jflory7: - Issue priority set to: waiting on assignee (was: awaiting triage) - Issue tagged with: PASSED, difficulty - easy, good first issue, help wanted, improvement, type - internal organization, type - summer coding
Metadata Update from @jflory7: - Issue assigned to jflory7
Metadata Update from @jflory7: - Issue untagged with: good first issue, help wanted
Metadata Update from @jflory7: - Assignee reset
Metadata Update from @jflory7: - Issue priority set to: waiting on external (was: waiting on assignee) - Issue tagged with: blocked
I didn't notice that folder only had upstream logos there. I think the purpose of the artwork/ directory isn't to serve the files in the Django site, but to make the source files available for many uses. For example, the upstream maintainer has created Happiness Packet stickers to hand out at conferences. Someone could use the CMYK PDF files in artwork/ to make their own.
artwork/
I would like to do the same for us, but with our project-specific logos. I think this ticket is actually blocked on #21. The Design Team is still working on logos, and they should be able to provide us multiple file formats once the work is complete.
For now, let's revisit this ticket after #21 is resolved so we can replace the upstream files with our artwork sources.
Metadata Update from @jflory7: - Custom field Requirement # adjusted to 26
For issue #21 PR is made at #234.
Metadata Update from @jflory7: - Issue unmarked as depending on: #21 - Issue untagged with: blocked - Issue priority set to: waiting on assignee (was: waiting on external) - Issue set to the milestone: Summer Coding 2019: phase 1
I split commit 4f448c4 out of PR #234 and pushed it to master. Since there is a different problem holding up #234, I figured it would be easier to get this easyfix task done since it only deletes the artwork/ directory.
master
Closing as complete. :clapper:
Metadata Update from @jflory7: - Issue close_status updated to: complete - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.