This is a great task for a beginner / newcomer to work on. :mag:

@jflory7 Hi, i would love to work on this issue as my first issue! Can I take it?

@jflory7 Hi, i would love to work on this issue as my first issue! Can I take it?

@anhpham Sure! It's all yours. :raised_hands: Let us know if you need any guidance.

Hi @jflory7 I'm having problems with committing my changes for pull request.
I have tried cloning the project both ways (ssh and git) and I did not succeed at both.
I will do my best to explain to you what i have done that leads to the error, if there's anything that is not clear yet please let me know!
So first I followed the instruction of setting up the environment (https://fedora-happiness-packets.readthedocs.io/setup/development/) until part 2. I could not clone the project using ssh. I set up the ssh key according this tutorial (https://docs.pagure.org/pagure/usage/first_steps.html) and uploaded my public ssh key to my FAS account settings like this:

And when I tried to use the command line as instructed (git clone "ssh://git@pagure.io/forks//fedora-commops/fedora-happiness-packets.git") I received the error:

I was confused at this and could not solve the problem, so I resorted to using git clone using git repository option like this:

And I was able to clone the project and see the code base in my IDE! However, after changing the code, committing the changes to a new branch and push origin to the branch i received the error:

I suppose the reason was because that the best way to commit changes for pull request to our project is to use ssh, not git.
Could you help me regarding this issue?

I have tried cloning the project both ways (ssh and git) and I did not succeed at both.
I will do my best to explain to you what i have done that leads to the error, if there's anything that is not clear yet please let me know!

When you try to run git clone, what is the output when it fails?

So first I followed the instruction of setting up the environment (https://fedora-happiness-packets.readthedocs.io/setup/development/) until part 2. I could not clone the project using ssh. I set up the ssh key and uploaded my public ssh key to my FAS account settings like this:

This part may not have been clear. Uploading the SSH key to FAS account is used for logging into Fedora Infrastructure machines and a few other places. For Pagure, you need to also upload your SSH key into Pagure. See docs on how to do this here.

(Edit: Sorry it was supposed to be an image there but I accidentally clicked sent. More details will come in the next comments)

No worries – I hope my ideas above are useful to help debug for now. I will be away for a few hours so I might not have a chance to reply right away.

I have tried cloning the project both ways (ssh and git) and I did not succeed at both.
I will do my best to explain to you what i have done that leads to the error, if there's anything that is not clear yet please let me know!

When you try to run git clone, what is the output when it fails?

So first I followed the instruction of setting up the environment (https://fedora-happiness-packets.readthedocs.io/setup/development/) until part 2. I could not clone the project using ssh. I set up the ssh key and uploaded my public ssh key to my FAS account settings like this:

This part may not have been clear. Uploading the SSH key to FAS account is used for logging into Fedora Infrastructure machines and a few other places. For Pagure, you need to also upload your SSH key into Pagure. See docs on how to do this here.

(Edit: Sorry it was supposed to be an image there but I accidentally clicked sent. More details will come in the next comments)

No worries – I hope my ideas above are useful to help debug for now. I will be away for a few hours so I might not have a chance to reply right away.

I just edited my comment with more details! Could you take a look at it and let me know if anything that is not clear?

@anhpham Oops, I see your screenshots now. It looks like you set everything up right, except for one part. Try typing git remote -v. You will see the remotes for your cloned project. You are using the HTTPS URL, which is okay for pulling changes but not pushing changes. You need to use the SSH URL as your remote for the project. There are two ways to fix this:

1. Re-clone the project with SSH URL and start fresh
2. Change remote URL in repo (git remote set-url origin <SSH URL>)

@jflory7 I think the issue might be different.
If you can please have a look at the first image here.
If you observe the last part, I guess the user name part.
@anhpham , can you confirm if that is the same email that you have used to login to the FAS account.

@jflory7 I think the issue might be different.
If you can please have a look at the first image here.
If you observe the last part, I guess the user name part.
@anhpham , can you confirm if that is the same email that you have used to login to the FAS account.

hi @phoenixabhishek , no, now that I've seen it, it's not the email I used to login to the FAS account. In fact, I don't think I have seen the email anywhere else and I'm quite confused why it exists in the first place.
I typed ssh-keygen in Terminal to generate the two keys to my computer and I really just copied the public key it gave me to the SSH key in my Profile Settings.

@anhpham In that case, go to your profile page of pagure, and click on the Email Addresses tab there you will see what email is in use.

Then you can copy that to the end of the SSH key.
Let's see if this works :sweat_smile: :sweat_smile: :sweat_smile: :sweat_smile: :sweat_smile:

P.S. you might have to delete the current SSH key, and add again with the actual email id.

@anhpham In that case, go to your profile page of pagure, and click on the Email Addresses tab there you will see what email is in use.
Then you can copy that to the end of the SSH key.
Let's see if this works 😅 😅 😅 😅 😅
P.S. you might have to delete the current SSH key, and add again with the actual email id.

Thank you so muchh! I'll give it a try and let you know of my progress!

Hi @phoenixabhishek @jflory7 , I deleted my old SSH key and generated a new one, this time changed the email at the end of the key to the correct email that I used to login to FSA:

Still I got this error:

I think the root of the issue is the key. Could I have an example of a SSH key to check if my public key is the correct one in the first place?

I think the root of the issue is the key. Could I have an example of a SSH key to check if my public key is the correct one in the first place?

Your last error indicates the key you uploaded to Pagure and the SSH key git is using to clone are different. It may be that the SSH key is not being picked up by git. I am assuming you are using either Linux or macOS. If so, you should have similar output:

$ ls -Alh ~/.ssh/
total 40K
-rw-r--r--. 1 jflory jflory  745 2018-09-02 18:24 authorized_keys
-rw-r--r--. 1 jflory jflory 1.6K 2019-03-03 19:18 config
-rw-------. 1 jflory jflory 3.3K 2017-07-27 17:57 id_rsa
-rw-r--r--. 1 jflory jflory  745 2016-09-21 02:39 id_rsa.pub
-rw-------. 1 jflory jflory 5.1K 2019-02-27 16:05 known_hosts

Can you confirm you see the id_rsa files in ~/.ssh?

@jflory7 @phoenixabhishek i was able to fix my problem after researching for various solutions online! Props to Stack Overflow: https://stackoverflow.com/questions/3828164/how-do-i-access-my-ssh-public-key
Here is what I did:
I accessed the ssh file in my computer by typing in Terminal: cd ~/.ssh
Then I checked in my .ssh folder if I have any keys by typing "ls". I did not have the two files id_rsa and id_rsa.pub available so I typed this command: ssh-keygen -t rsa -C to generate the keys.
Then I accessed my public key file by typing: ssh-agent sh -c 'ssh-add; ssh-add -L'
I copied the content of the public key by : pbcopy < id_rsa.pub
Then went over to my Profile Settings to pasted the key to SSH Key.
Then I used git clone ssh:... again and it worked! I successfully cloned the project to my computer!

Right now I'm still not sure if I could commit for pull request yet but at least I finished the project set up step! Will let you know if the problem has been fully solved or not! Thank you ❤️

Right now I'm still not sure if I could commit for pull request yet but at least I finished the project set up step! Will let you know if the problem has been fully solved or not! Thank you <3

Super, nice sleuthing! :mag: Glad you got it figured out. :tada: You should also be able to push a commit to your fork now too, if you were able to successfully clone.

Right now I'm still not sure if I could commit for pull request yet but at least I finished the project set up step! Will let you know if the problem has been fully solved or not! Thank you <3

Super, nice sleuthing! 🔍 Glad you got it figured out. 🎉 You should also be able to push a commit to your fork now too, if you were able to successfully clone.

Thank you so much! I still haven't fully understood the reason for my problem yet but I'm glad I figured it out regardless! I hope future developers who faced the same problem as mine will also be able to solve it after looking at my comment ^^

@jflory7 I wanted to test my code by sending some happiness packets. So i clicked on the button "Send some happiness packets" and filled out my info and click "Send". Then Fedora asked to click on the confirmation link sent to my email, but there's no email at all.

What is the best way I can do to test my code changes if I could not receive any confirmation emails to finalize my happiness packets sending at first?

@anhpham Let me know if my advice in IRC is helpful for short-term debugging. :smiley:

@anhpham Let me know if my advice in IRC is helpful for short-term debugging. 😃

Thank you so much @jflory7 ! I also saw the Email issue in the Issues section of the project. I'm aware that we can send and receive the happiness packets through the console because of the "CELERY_EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend" in dev.py.
However, I'm new to debugging Django though so I'm not familiar with short-term debugging through console yet. Could you help guide me on which steps I could do (or are there any documentations I could read) for doing that?

However, I'm new to debugging Django though so I'm not familiar with short-term debugging through console yet. Could you help guide me on which steps I could do (or are there any documentations I could read) for doing that?

Sure. While running your development environment with docker-compose, try sending a test Happiness Packet in the browser (doesn't matter what name or email you use). Once you click "Send" and you get the message about confirming via email, take a look at the window where you ran docker-compose. In that window, you will see a lot of things, but you should see the full text of the email in the console as well. You can find the confirmation URL in the output in the console window.

Does this make sense? Let me know if you are able to figure it out. :thumbsup:

However, I'm new to debugging Django though so I'm not familiar with short-term debugging through console yet. Could you help guide me on which steps I could do (or are there any documentations I could read) for doing that?

Sure. While running your development environment with docker-compose, try sending a test Happiness Packet in the browser (doesn't matter what name or email you use). Once you click "Send" and you get the message about confirming via email, take a look at the window where you ran docker-compose. In that window, you will see a lot of things, but you should see the full text of the email in the console as well. You can find the confirmation URL in the output in the console window.
Does this make sense? Let me know if you are able to figure it out. 👍

Yes it makes sense and I have figured that out, thanks to you @jflory7 ! 👍👍👍
I will make my first pull request now :) 👍

@anhpham completed this in #163. Thanks @anhpham! Closing this ticket as complete. :clapper: