I believe that setting the architecture label in every layered Dockerfile is not necessary, it might be even problematic once we'll have containers on non-intel platforms, because then we'd need to either maintain more copies of Dockerfiles with different architecture labels or remove it later (when we'll have more layered Dockerfiles to maintain at that point).
So, I'd like to propose to set the architecture label in the container base image, so it is inherited in the layered images and we don't need to hard-code it there. Then, setting architecture label should be made prohibited (or obsolete) in https://fedoraproject.org/wiki/Container:Guidelines.
Metadata Update from @maxamillion: - Issue assigned to maxamillion
Do you want this to be a LABEL or an ENV?
Metadata Update from @maxamillion: - Issue tagged with: meeting
Discussed in the atomic working group meeting today. The proposal in the description sounds reasonable. Assuming we need to set an architecture label, then making layered images inherit from the base image makes sense. This assumes that there is not some technical reason why this can't be achieved.
+1
Metadata Update from @dustymabe: - Issue untagged with: meeting
PR Submitted to imagefactory to add this functionality. https://github.com/redhat-imaging/imagefactory/pull/402
Once merged, we'll get the configurations in place with pungi-fedora
Metadata Update from @dustymabe: - Issue tagged with: containers
I believe this is done now.
{ "Name": "candidate-registry.fedoraproject.org/f27/greenwave", "Digest": "sha256:abda79af6349e8ff09fb35500477d71c01f4607e90721d60b8d010fe51097aab", "RepoTags": [ "rawhide-container-candidate-49347-20180212083824", "f27-91008-20180218082622", "f27-container-candidate-75796-20180314172356" ], "Created": "2018-03-14T17:27:32.444383Z", "DockerVersion": "1.13.1", "Labels": { "architecture": "x86_64",
Metadata Update from @cverna: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.