I think the container guidelines should include a section about the Layered Images used as a base for other Layered Builds. I've created an updated draft that also fixes label names to use the lower-case convention:
https://fedoraproject.org/wiki/User:Hhorak/Draft/Container:Review_Process
Now I realized it should be Container:Guidelines, because it updates https://fedoraproject.org/wiki/Container:Guidelines.. so the link is misleading a bit..
Metadata Update from @kushal: - Issue tagged with: containers, meeting
In general, the text seems fine, with a few fixes for labels we changed, etc.
@maxamillion , what would the actual FROM line look like?
FYI, I have images like this now:
http://pkgs.fedoraproject.org/cgit/docker/kubernetes-apiserver.git/tree/Dockerfile?h=f25
FROM registry.fedoraproject.org/f25/kubernetes-master:latest
What @jasonbrooks said.
@maxamillion so tha tis the accepted way and we can only use base images that are provided in the fedora registry? If so can we close this ticket?
We can use any image in the Fedora registry as a base image. So if that's what you mean, then yes. (I'm not sure I understand completely so I wanted to clarify)
What about the labels variant? The Fedora guidelines still use BZComponent or Architecture, while the Fedora OSBS is currently fine with the newer variant com.redhat.component or architecture.. Is it possible to change the guidelines, so we don't have many images with obsolete variants?
Similarly with the uppercase first letters in labels (Name, Version, Release...). Are these really required to be uppercase or should the doc be updated?
Thanks for the quick turn-around, it looks like resolved now.
@hhorak - can you summarize the resolution and then I'll close this ticket? - thanks
In the Cloud WG meeting on 12-Apr-2017, we discussed closing this ticket.
Based on my read of the comments and the current version of the Container Guidelines we have addressed all concerns: - the Container Guidelines have been updated with examples on how to use base images and layered images in the FROM line - the Guidelines show labels using lower-case convention
If there are other issues that need to be addressed, please open a separate ticket for them.
Metadata Update from @dustymabe: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.