#206 Move nginx container image from Fedora-Dockerfiles GitHub into DistGit
Closed: Fixed 4 years ago Opened 5 years ago by maxamillion.


And I'll take this one.

A similar review request for almost same container is in:
https://bugzilla.redhat.com/show_bug.cgi?id=1421605
Although that one should work fine in OpenShift as well, so I proposed to prefer BZ#1421605 over BZ#1420947.

I'm fine with that provided the BZ#1421605 Dockerfile gets updated to meet the same specifications as far FROM being the official fedora registry and keeping the label conventions in BZ#1420947. Those come from the guidelines on the wiki here: https://fedoraproject.org/wiki/Container:Guidelines

Does that work Honza? Thanks for pointing out the duplicate! I guess I shoulda looked around for those before...

This is a good point, thanks for that. It think the guidelines don't cover the case where we have FROM fedora:25 for image A and then FROM A for image B. In my opinion this will be quite common case and we should have it covered in the guidelines. So, my view on this is that we should rather work on the guidelines to cover this, I can help Adam with this as part of this issue. Does this make sense?

Metadata Update from @dustymabe:
- Issue tagged with: containers

5 years ago

can we do something with this now that we have it there?

https://src.fedoraproject.org/container/nginx

the content is already in the repo in the master branch: all that is needed now is to put the dockerfile to f27 branch and build it

the content is already in the repo in the master branch: all that is needed now is to put the dockerfile to f27 branch and build it

yes, who can do that?

This is now in the registry, so we can close this ticket

This is now in the registry, so we can close this ticket

you have ticket access now so you should be able to close tickets!

Metadata Update from @dustymabe:
- Issue set to the milestone: None (was: 2017-02-09 VFAD)

4 years ago

Metadata Update from @cverna:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata