#120 Allow specifying additional result outcomes in openshift template.
Merged 5 years ago by ralph. Opened 5 years ago by ralph.
taskotron/ ralph/resultsdb additional-outcomes  into  develop

@@ -31,6 +31,9 @@ 

    displayName: Secret Key for ResultsDB

    generate: expression

    from: "[\\w]{32}"

+ - name: RESULTSDB_ADDITIONAL_RESULT_OUTCOMES

+   displayName: Additional outcomes values.

+   value: "[]"

  objects:

  - apiVersion: v1

    kind: Secret
@@ -61,6 +64,7 @@ 

        MESSAGE_BUS_PUBLISH = False

        MESSAGE_BUS_PLUGIN = 'fedmsg'

        MESSAGE_BUS_KWARGS = {'modname': 'resultsdb'}

+       ADDITIONAL_RESULT_OUTCOMES = ${RESULTSDB_ADDITIONAL_RESULT_OUTCOMES}

  - apiVersion: v1

    kind: ConfigMap

    metadata:

This can be used like this:

$ oc process --local -f ./openshift/resultsdb-test-template.yaml \
    -p TEST_ID=test \
    -p RESULTSDB_ADDITIONAL_RESULT_OUTCOMES=\[\'SOMETHING\'\]

In particular, it will be used by the Greenwave test suite which expects to be
able to run some tests against resultsdb with varying kinds of outcomes.

rebased onto 1552254

5 years ago

Hey, just a quick note - seems like you have not based the PR on the develop's HEAD, could you please make sure that you rebase and only include the relevant commit? Thanks!

Ah, that's what I get for being too fast :) disregard the previous comment, @ralph :)

Lol! We were both confused by it @jskladan. I fixed as soon as I realized what I'd done.

OK, I'm going for it. @jskladan, if you're opposed we can certainly back it out.

Thanks guys!

Pull-Request has been merged by ralph

5 years ago
Metadata