PR#5: Extend ABI check for ppc64, ppc64le and aarch64 arch packages - task-abicheck

task-abicheck

#5 Extend ABI check for ppc64, ppc64le and aarch64 arch packages

Merged 7 years ago by sinnykumari. Opened 7 years ago by sinnykumari.

arch_enable into develop

Extend ABI check for ppc64, ppc64le and aarch64 arch packages

Sinny Kumari • 7 years ago

7cf70b5

run_abipkgdiff.py

file modified

+10 -5

		`@@ -11,7 +11,7 @@`


		`def run_abipkgdiff(koji_build, stable_rpmsdir, update_rpmsdir,`
		`- arches=('x86_64', 'i686', 'armv7hl'), artifactsdir='artifacts'):`
		`+ arches=('x86_64', 'i686', 'armv7hl', 'ppc64le', 'ppc64', 'aarch64'), artifactsdir='artifacts'):`
		`# Create artifacts directory if doesn't exist`
		`process_start_time = time.time()`
		`if not os.path.exists(artifactsdir):`
		`@@ -60,7 +60,9 @@`

		`# Get debuginfo rpm for specified architecture`
		`for rpm in os.listdir(stable_rpmsdir):`
		`- if arch in rpm:`
		`+ # dot(.) is needed during search to avoid getting result from ppc64le`
		`+ # arch while searching fro ppc64`
		`+ if (arch + ".") in rpm:`
		`if 'debuginfo' in rpm:`
		`stable_debuginfo_rpm.append(rpm)`
		`else:`
		`@@ -76,7 +78,9 @@`
		`abipkgdiff on them`
		`'''`
		`for rpm in os.listdir(update_rpmsdir):`
		`- if arch in rpm:`
		`+ if (arch + ".") in rpm:`
		`+ # dot(.) is needed during search to avoid getting result from ppc64le`
		`+ # arch while searching fro ppc64`
		`if 'debuginfo' in rpm:`
		`update_debuginfo_rpm.append(rpm)`
		`else:`
		`@@ -113,8 +117,9 @@`

		`for update_rpm in update_rpms_detail:`
		`for stable_rpm in stable_rpms_detail:`
		`- if stable_rpm['name'] != update_rpm['name']:`
		`- continue`
		`+ if (stable_rpm['name'] != update_rpm['name']) or \`
		`+ (stable_rpm['arch'] != update_rpm['arch']):`
		`+ continue`
		`update_rpms.remove(update_rpm['rpm'])`
		`stable_rpms.remove(stable_rpm['rpm'])`

runtask.yml

file modified

+2 -2

		`@@ -17,7 +17,7 @@`
		`koji:`
		`action: download_latest_stable`
		`koji_build: ${koji_build}`
		`- arch: ['all']`
		`+ arch: ['x86_64', 'i386', 'armv7hl', 'ppc64le', 'ppc64', 'aarch64']`
		`arch_exclude: ['noarch']`
		`debuginfo: True`
		`target_dir: ${workdir}/stable`
		`@@ -26,7 +26,7 @@`
		`koji:`
		`action: download`
		`koji_build: ${koji_build}`
		`- arch: ['all']`
		`+ arch: ['x86_64', 'i386', 'armv7hl', 'ppc64le', 'ppc64', 'aarch64']`
		`arch_exclude: ['noarch']`
		`debuginfo: True`
		`target_dir: ${workdir}/update`

sinnykumari commented 7 years ago

Since Fedora 26, primary koji also builds a package for
ppc64, ppc64le and aarch64 arches. It is possible to
ask taskotron to extend an abicheck task run for these
arches

kparal commented 7 years ago

We haven't really had any discussion whether we want to recommend tasks to only test primary arches in Taskotron at this moment, or also test alternate arches if possible. So either way is fine. But I believe you should replace 'i686' with 'i386' when calling the koji directive.

rebased

7 years ago

sinnykumari commented 7 years ago

Thanks Kamil for review!
I understand that right now Taskotron tasks doesn't run for alternative arch packages. I find it useful to run abicheck task on all arch packages because it might expose arch specific ABI changes.

Also, updated koji directive for arch from i686 to i386

Pull-Request has been merged by sinnykumari

7 years ago