#7 Bad report about ABI change for PHP packages
Opened 7 years ago by kparal. Modified 6 years ago

This has been reported as taskotron#242:

Ex: https://taskotron.fedoraproject.org/artifacts/all/3dd146e8-cf54-11e7-a1d7-525400817a8f/task_output/php-7.1.12-1.fc27.log
Each package provides 2 extensions, ex:
$ rpm -ql php-odbc
/usr/lib64/php-zts/modules/odbc.so
/usr/lib64/php/modules/odbc.so

I think that in some case, it compares NTS vs ZTS extension, which have some difference, so the report raise some false positives.


Thanks @tflink and @kparal for reporting this issue. It seems to be a bug in libabigail's abipkgdiff tool. I have reported bug for same in upstream libabigail - https://sourceware.org/bugzilla/show_bug.cgi?id=22488

I fixed https://sourceware.org/bugzilla/show_bug.cgi?id=22488 upstream. So that issue should now be fixed. Thanks for raising this @tflink and @kparal!

Shouldn't we close this issue now?

Remi Collet pagure@pagure.io a =C3=A9crit:

remi added a new comment to an issue you are following:
``
Taskotron still affected, probably running an old version

https://taskotron.fedoraproject.org/artifacts/all/b8efa1b2-01ae-11e8-81b5=
-525400fc9f92/task_output/php-7.2.2~RC1-3.fc28.log
``

Right, I just checked, and I really need to release libabigail 1.1 asap,
as taskotron seems to be using 1.0.

Sorry about this.

--=20
Dodji

Right, I just checked, and I really need to release libabigail 1.1 asap,
as taskotron seems to be using 1.0.

We're using whatever is available in Fedora repos :-)

Kamil P=C3=A1ral pagure@pagure.io a =C3=A9crit:

kparal added a new comment to an issue you are following:
``

Right, I just checked, and I really need to release libabigail 1.1 asap,
as taskotron seems to be using 1.0.

We're using whatever is available in Fedora repos :-)

Good!

It just happens that I have released libabigail 1.1 today and RPMs have
been rolled out too. Hopefully this issue should be released then.

Thanks!

--=20
Dodji

Hello,
It seems this error is still being seen, even though there is a fix in Libabigail 1.1 for it. Thus, It looks like task-abicheck hasn't been updated to use libabigail version >= 1.1. Can we move to libabigail >= 1.1 please?

https://taskotron.fedoraproject.org/artifacts/all/b6d98e3a-2790-11e8-8c58-525400fc9f92/tests.yml/php-7.2.4~RC1-1.fc29.log

Thanks.

I think that might have been caused by Rawhide composes not being successful for some time around that time. Hard to guess. On taskotron-dev, we now create a tests.yml/taskotron/rpm-qa.log file that lists all installed packages, so I'm able to verify that libabigail 1.2 is being used on fc29 (example). Except for F28, where it's not stable yet. So if you have some example from the last 2 days, you can have a look on taskotron-dev and see the package version right away. This will be deployed to production once Beta freeze ends.

Also, we really use what's in the repos, there's no special magic to task-abicheck, honest :-)

Metadata Update from @kparal:
- Issue assigned to dodji

6 years ago

Log in to comment on this ticket.

Metadata