rpkg

#82 Output both stdout and stderr when not in tty
Merged by cqi. Opened by cqi.
cqi/rpkg fix-output-both-stderr-stdout  into  master

Download 82.patch

Output both stdout and stderr so that all of them can be redirected to
other destination.

Signed-off-by: Chenxiong Qi cqi@redhat.com

This exception was not raised before as far as I can see. I think it would be nice to add some information to it. Either an error message or maybe better raise a new subclass of rpkgError.

This is essentially doing the same thing as subprocess.check_call, right?

I like this simplification. Now the branches for TTY and non-TTY look almost identical. Can we maybe get rid of them and do the same thing? (Not necessarily in this pull request.)

return code is handled in the way below at line 32, so I dropped to use subprocess.check_call.

check_all should be used as much as possible when I refactor _run_command according to your comment

I like this simplification. Now the branches for TTY and non-TTY look almost identical. Can we maybe get rid of them and do the same thing? (Not necessarily in this pull request.)

I'll try to refactor this piece of code in another PR.

rebased

Cool. :thumbsup:

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.