rpkg

#390 Add config options to parse the base module (e.g. platform) stream from the dist-git branch and apply a buildrequire override
Merged by lsedlar. Opened by mprahl.
Unknown source master

Download 390.patch

Addresses the final part of FACTORY-3084 and relies on #389. Only the last commit is relevant to this PR.

@cqi @jkaluza @ralph could you please review?

Can you put an example regex in a comment here? It would help a code reader understand how ''.join(branch_search.groups()) down below.

LGTM.

2 new commits added

  • Add config options to parse the base module (e.g. platform) stream from the dist-git branch and apply a buildrequire override
  • Add the ability to pass in buildrequire and require overrides on a module build

@ralph thanks for the review. I added the comment as requested.

@lsedlar could you please review this as well?

Generally looks good to me. :thumbsup:

The regex handling currently allows to remove parts from the branch string, but not add anything. As far as I can tell, that is sufficient now. Do you foresee any change in the requirements?

rebased onto 89e34eb68d5a01eb11c09974391b83348850338a

rebased onto 80a3d1fc008f211d60730a0f3a60732ade48c767

Pull-Request has been merged by lsedlar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.