#11251 critpath.py: don't crash if a group is missing on an arch
Merged a year ago by kevin. Opened a year ago by adamwill.
adamwill/releng critpath-fix-missing-group  into  main

file modified
+7 -1
@@ -19,6 +19,7 @@ 

  from tempfile import mkdtemp

  from urllib.request import urlopen

  import dnf

+ import dnf.exceptions

  

  

  class SackError(Exception):
@@ -153,7 +154,12 @@ 

              # load up the comps data from configured repositories

              base.read_comps()

              group = group.replace("@", "")

-             base.group_install(group, ["mandatory", "default", "optional"], strict=False)

+             try:

+                 base.group_install(group, ["mandatory", "default", "optional"], strict=False)

+             except dnf.exceptions.CompsError as err:

+                 if str(err).startswith("Group id") and str(err).endswith("does not exist."):

+                     print(f"Warning: group {group} does not exist for arch {conf.arch}")

+                     continue

              # resolve the groups marked in base object

              base.resolve()

              packages[group] = base.transaction.install_set

Nothing in critical-path-standard exists on s390x, apparently,
and the script didn't like that.

Signed-off-by: Adam Williamson awilliam@redhat.com

Pull-Request has been merged by kevin

a year ago
Metadata