Learn more about these different git repos.
Other Git URLs
Recently, we've noticed a few packages that were previously tagged in coreos-pool have been tagged out. A few weeks ago, the following packages were untagged:
We tagged those back in manually. Today, I noticed that glib2-2.62.3-1.fc31 was also tagged out. It's highly likely that there are more packages that have been untagged that we haven't noticed yet.
Having packages we tag into coreos-pool stay there is a basic assumption we need in order to deliver a stable pipeline for FCOS.
A few questions: 1. is there a way to know what caused these packages to be tagged out? 2. can we tighten ACLs around tagging things out of coreos-pool to make sure this doesn't happen accidentally?
It's not urgent, but still very concerning.
When we stop using coreos-pool.
We cannot reliably deliver reproducible FCOS builds.
The "koji list-history --tag=coreos-pool" command will tell you what was tagged/untagged and by who. From there you should be able to acsertain what has been added/removed
It's pretty clearly the garbage collection setup. :)
So, we need to tell it to not untag things in coreos-pool? Are there any other tags that should always stay?
So, we need to tell it to not untag things in coreos-pool?
Yes please! :) (To be clear, we don't expect to keep them in the pool forever either, but it would be safer if we took care of untagging for GC on our end.) What can I do to help? If you point me at the config, I can submit a patch.
Are there any other tags that should always stay?
I think that's the only one. We also have fxx-coreos-continuous tags, though those can/should have older packages pruned.
fxx-coreos-continuous
So, we need to tell it to not untag things in coreos-pool? Yes please! :) (To be clear, we don't expect to keep them in the pool forever either, but it would be safer if we took care of untagging for GC on our end.) What can I do to help? If you point me at the config, I can submit a patch.
I think this will do it:
diff --git a/roles/koji_hub/templates/koji-gc.conf.j2 b/roles/koji_hub/templates/koji-gc.conf.j2 index ff07fc7..a35e91c 100644 --- a/roles/koji_hub/templates/koji-gc.conf.j2 +++ b/roles/koji_hub/templates/koji-gc.conf.j2 @@ -91,6 +91,9 @@ policy = tag module-* :: keep tag *-modular :: keep + # coreos-pool is used for coreos releases, keep it always + tag coreos-pool :: keep + #stuff to protect #note that tags with master lock engaged are already protected tag *-updates :: keep
However, we are in beta freeze right now. Would you like me to request a freeze break for it? Or can it wait until after beta?
Probibly it would be good to do now to avoid having to re-tag things?
Are there any other tags that should always stay? I think that's the only one. We also have fxx-coreos-continuous tags, though those can/should have older packages pruned.
ok.
thanks @jlebon and @kevin for looking into this
Closing this ticket.
Please reopen if the problem still persists.
Metadata Update from @mohanboddu: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Its not fixed yet, the patch is ready but not pushed due to the f32 beta freeze.
Reopening the ticket.
Metadata Update from @mohanboddu: - Issue status updated to: Open (was: Closed)
Pushed this change. Should be active after today.
Sorry for the delay.
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.