#6834 opt to arg parse remnants in sign script
Closed: Fixed 6 years ago Opened 6 years ago by parasense.

I was doing a --write-all for thing thing I was signing, and looks liek somebody converted to arg parse, but forgot a reference to optparse. Trivial fix. Here is the diff.

diff --git a/scripts/sigulsign_unsigned.py b/scripts/sigulsign_unsigned.py
index c9dff3a..0bbce56 100755
--- a/scripts/sigulsign_unsigned.py
+++ b/scripts/sigulsign_unsigned.py
@@ -223,7 +223,7 @@ def writeRPMs(status, kojihelper, batch=None):
        Returns status, increased by one in case of failure"""

     # Check to see if we want to write all, or just the unsigned.
-    if opts.write_all:
+    if args.write_all:
         rpms = rpmdict.keys()
     else:
         if batch is None:

PR incoming.


Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata