#7 Do not obsolete approved request by default
Closed: Fixed None Opened 12 years ago by ppisar.

I run {{{./pkgdb.py request perl-Template-Tiny commit all}}} to request for commit permissions on branches where I'm not already approved and guess what happened. It removed my permission where I was already approved:

{{{
Obsolete for ppisar on package perl-Template-Tiny branch devel
Awaiting Review for ppisar on package perl-Template-Tiny branch F-13
Awaiting Review for ppisar on package perl-Template-Tiny branch f14
Obsolete for ppisar on package perl-Template-Tiny branch f15
}}}

I found in help output it's a feature. I think this is not good idea. I'd like to have ''request'' for requesting for a permission (i.e. to add), and new action (e.g.) ''remove'' to make it obsolete.

The use case is the request to have accumulating effect.


Or instead of adding new action you can add switches ''--add'' and ''--remove'' like action ''update'' has ''--approve'' and ''--deny'' to be consistent.

This is a valid point. The problem is that I rely on a "toggle" function. So it basically toggle to request if you don't have it and toggle as deny if you do have it.

Add/Remove ACL might be something to add to pkgdb itself which I could then use in a more user friendly way.

Thanks for the report

After adding some logic in pkgdb, I just pushed the changes in the client to fix this issue.

Let me if you still run into it.

Login to comment on this ticket.

Metadata