#5381 [WIP][feature] Enable collaborators to merge the PR(s)
Closed 2 months ago by ngompa. Opened a year ago by jnsamyak.

@@ -170,7 +170,7 @@ 

                </a>

                <div id="merge-alert" class="text-xs-center dropdown-menu dropdown-menu-right p-0">

                  <div class="alert text-center mb-0">

-                   {% if g.repo_committer %}

+                   {% if g.repo_committer or g.fas_user.username in g.repo.collaborators %}

Looks like you're just outside the {% if g.authenticated ... check from line 138, here (it closed on line 164), so you'd have to check again before using g.fas_user.

Suggestion:

{% if g.authenticated and (g.repo_committer or g.fas_user.username in g.repo.collaborators) %}

                      <small id="merge-alert-message"></small>

                      <form action="{{ url_for('ui_ns.merge_request_pull',

                          repo=repo.name,

This PR enables collaborators to merge, while not restricting the people with committer access to merge the pull request.
Please refer to this issue for the relevant request/use-case reference.

Ugh, the CI is failing because somehow all the old Fedora release tags for the container image at quay.io were deleted. :frowning:

pretty please pagure-ci rebuild

11 months ago

rebased onto ab6c0422609330388e0f4c309c34c64f40dcb710

11 months ago

pretty please pagure-ci rebuild

11 months ago

pretty please pagure-ci rebuild

11 months ago

On my todos for this week, hopefully will get a workaround to it :D

rebased onto 22afe7823663c5b803b988562d287c4d42aba980

8 months ago

rebased onto f2532db

6 months ago

rebased onto 3f5af2c

3 months ago

Looks like you're just outside the {% if g.authenticated ... check from line 138, here (it closed on line 164), so you'd have to check again before using g.fas_user.

Suggestion:

{% if g.authenticated and (g.repo_committer or g.fas_user.username in g.repo.collaborators) %}

Pull-Request has been closed by ngompa

2 months ago
Metadata