PR#1125: Add the possibility to create projects with names of 40 chars length -

pagure

#1125 Add the possibility to create projects with names of 40 chars length

Merged Jul 16, 2016 by pingou. Opened Jul 15, 2016 by pingou.

allow_40_chars into master

pingou commented Jul 15, 2016

Newer pagure instances do not need this restriction

vivekanand1101 commented Jul 15, 2016

thanks for doing my part of the job :grin: :thumbsup:

vivekanand1101 commented Jul 16, 2016

I had a look later and i think this is doing exact opposite of what's required.
When OLD_VIEW_COMMIT_ENABLED = True, then the project with 40 chars after '/' shouldn't be created. But, according to this: prevent_40_chars will get the value True here and if len(second_part) == 40 and not prevent_40_chars will evaluate to False here thus, the exception won't be raised.

pingou commented Jul 16, 2016

Good point and the tests should have made it obvious...

Let me fix that

1 new commit added

Invert the logic around prevent_40_chars to actually do what we want

Jul 16, 2016

rebased

Jul 16, 2016

vivekanand1101 commented Jul 16, 2016

:thumbsup:

pingou commented Jul 16, 2016

Thanks

Pull-Request has been merged by pingou

Jul 16, 2016

Metadata

Assignee

None

Tags

No Tags

pagure

#1125 Add the possibility to create projects with names of 40 chars length Merged Jul 16, 2016 by pingou. Opened Jul 15, 2016 by pingou. allow_40_chars into master

Metadata

#1125 Add the possibility to create projects with names of 40 chars length

Merged Jul 16, 2016 by pingou. Opened Jul 15, 2016 by pingou.

allow_40_chars into master