#4433 Unable to edit my own comments on pagure.io
Closed: Won't Fix by wombelix. Opened by szpak.

I don't see an edit icon in my own comments on pagure.io. For example in copr/copr:
https://pagure.io/copr/copr/issue/670#comment-566642
(screenshot included)

For the same repo, some other people can edit the comments.

I'm still able to edit the issue I created, but not my comments placed in that issue.

Can it be related to #4210 (I refreshed the page - no effect).


The issue was also reported in https://pagure.io/pagure/issue/4469 and it seems to be because the namespace is missing somewhere.

Metadata Update from @pingou:
- Issue tagged with: bug

Took me a little bit to track this down and this is because we apparently do not allow non-committers to edit their comments once the ticket or PR is closed/merged.

It's a trivial 3-liners if we believe it should be changed:
https://pagure.io/pagure/blob/6a7b20d9e30a90db2028254ffb0507b467899da7/f/pagure/templates/_formhelper.html#_168

Metadata Update from @jlanda:
- Issue tagged with: easyfix

Personally I don't think that changes should be possible if something is closed.
No one voted to implement this in three years, I close the issue in favor of reducing our open ticket count.

Metadata Update from @wombelix:
- Issue close_status updated to: Won't Fix
- Issue status updated to: Closed (was: Open)

rokejulianlockhart commented

@wombelix, every other tracker provides the ability to, because conversations that cause a closed ticket to reopen must, first, be conducted on the closed ticket.

fedora-infrastructure/issue/12294#comment-993337 is a pertinent example of me not realising quite how basic your CommonMark parser is (it doesn't appear to understand ~~~, as a counterpart for the three backticks that are equivalent to <pre><code>).

I advise that this be reconsidered.

rokejulianlockhart commented

Albeit tangential, I've since ascertained that the cause was it not supporting <pre><code> inside of a <blockquote>. I intended to, now, say that this is another example of why comments should, here, be modifiable. However, I'm perplexed that #comment-993338 is.

rokejulianlockhart commented

...And as another demonstration, it turns out that I solely see those edit buttons until a location.reload(), due to pagure/issue/5517.

@rokejulianlockhart I'm not part of the pagure maintainer anymore, not my call to make. I suggest checking out the pagure matrix room to get in touch with someone. I guess a pull request from you is welcome if you want to change the behavior.

Metadata