Issue #3868: Refactor the logic about diff in a single place - pagure

pagure

#3868 Refactor the logic about diff in a single place

Closed: Fixed 5 years ago Opened 5 years ago by pingou.

Currently, the logic to determine if a file was added/modified/deleted is present in three places:
- repo_pull_request.html
- _repo_renderdiff.html
- pagure.api.forks.py

We should re-factor this to have it in one place (potentially, pagure.lib.git) which we could then call from the API as well as from a Jinja filters to be used in the templates.

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

pingou commented 5 years ago

Commit f6a6e0c fixes this issue

Metadata

Assignee

pingou

Tags

Blocking

None

Depending on

None

Priority

None

Milestone

5.2

Related Pull Requests

#4067 Merged 5 years ago

pagure

Source Code

Documentation

#3868 Refactor the logic about diff in a single place Closed: Fixed 5 years ago Opened 5 years ago by pingou.

Metadata

debt

Related Pull Requests

#3868 Refactor the logic about diff in a single place

Closed: Fixed 5 years ago Opened 5 years ago by pingou.