#2077 Commenting on a line of code took me back to the Comments tab
Closed: Fixed 6 years ago Opened 7 years ago by bowlofeggs.

After adding this comment on a pull request, my browser took me back to the Comments tab on the pull request. I expected to stay on the code view so I could continue adding comments.


I suspect there was something wrong with the SSE server then. in those case it will submit the form in the regular way and just reload the page entirely.

Can you reproduce this regularly of was it a one-time thing?

Metadata Update from @pingou:
- Issue tagged with: bug

7 years ago

@pingou I haven't seen this happen since the time I reported it.

@bowlofeggs ok, then I'm going to close this, I do think there was something wrong with the SSE server then.

Note that if you were not on a known/regular network, it could also have been the network you were on then that might have not allowed to connect to the port of the SSE, I know @vivekanand1101 had this for a while

Metadata Update from @pingou:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

7 years ago

This just happened again.

Metadata Update from @bowlofeggs:
- Issue status updated to: Open (was: Closed)

6 years ago

It just happened one more time, so I think something is definitely wrong.

This bug is becoming debilitating - I just reviewed https://pagure.io/pag/pull-request/15 and every single comment I typed took me back to the comments tab and I lost my place in the code. It's mentally taxing to lose your place every time you have something to say on a pull request.

Wouldn't it be better if it submitted the comment asynchronously and didn't rely on the SSE server at all to render? Since it's a comment we're submitting, it knows what the text is to render the comment after the server returns 200.

This is happening again today with https://pagure.io/pagure/pull-request/3054 - it's very frustrating. I lose my place in the PR review every time I add a comment.

Looks like stunnel got overwhelmed, I just restarted it, let's see if that helps

Login to comment on this ticket.

Metadata