#1023 %systemd_requires should be %{?systemd_requires}?
Closed: Fixed 7 months ago by tibbs. Opened 2 years ago by ankursinha.

I ran into this for one of my packages. I don't understand the issue fully, but apparently, the usage of %systemd_requires is wrong in the docs. It should be %{?systemd_requires}. Otherwise the build keeps failing with "Unknown tag: %systemd_requires".

Related to docs here:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets


I was the one that suggested it should be %{?systemd_requires} because from the IRC discussion, it sounded like systemd-rpm-macros wasn't getting pulled into the srpm creation build root, so the srpm creation failed due to rpmbuild thinking it had encountered an unknown tag (even though it was actually an unexpanded macro).

Yeah, this makes sense to change.

+1

I don't know if this is still an issue, but just in case it is I have filed #1128 . As far as I can tell, it shouldn't hurt anything either way though of course we'd always like to use the least confusing (less line-noisy) versions if possible.

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1128 Merged 7 months ago