#3 Package fsleyes
Opened 2 months ago by ankursinha. Modified 2 months ago


Metadata Update from @ankursinha:
- Issue tagged with: S: Needs packaging

2 months ago

Metadata Update from @ankursinha:
- Issue tagged with: F: Neuroimaging

2 months ago

Metadata Update from @ankursinha:
- Issue marked as depending on: #106

2 months ago

Metadata Update from @ankursinha:
- Issue marked as depending on: #107
- Issue marked as depending on: #108
- Issue marked as depending on: #109

2 months ago

Metadata Update from @ankursinha:
- Issue untagged with: S: Needs packaging
- Issue tagged with: S: Needs review

2 months ago

Metadata Update from @ankursinha:
- Issue untagged with: S: Needs review
- Issue tagged with: S: In testing

2 months ago

@ankursinha

I've tried to install the python3-fsleyes in fedora 29 (both locally and in the container), but there is probably a naming problem:

$ sudo dnf install  python3-fsleyes
Error: 
 Problem: conflicting requests
  - nothing provides python3dist(fslpy-props) needed by python3-fsleyes-0.26.4-1.fc29.noarch

Isn't it fsleyes-props, not fslpy-props? I've also tried --enablerepo=updates-testing, but without success.

Thanks for your work!

Ah, yes, you're right! Sorry---I messed up. Pushing an update now!

Ah, yes, you're right! Sorry---I messed up. Pushing an update now!

No problem, I'll test the new builds soon. Thanks for the quick fix!

@ankursinha Not sure if it is due to my setup, but fsleyes does not work for me:

$ fsleyes 
Traceback (most recent call last):
  File "/home/flachman/.local/bin/fsleyes", line 7, in <module>
    from fsleyes.main import main
  File "/usr/lib/python3.7/site-packages/fsleyes/__init__.py", line 207, in <module>
    import fsleyes.plugins                    as plugins
  File "/usr/lib/python3.7/site-packages/fsleyes/plugins.py", line 175, in <module>
    import fsleyes.views.viewpanel       as viewpanel
  File "/usr/lib/python3.7/site-packages/fsleyes/views/viewpanel.py", line 21, in <module>
    import fsleyes.panel                 as fslpanel
  File "/usr/lib/python3.7/site-packages/fsleyes/panel.py", line 392, in <module>
    import wx.siplib as sip
ModuleNotFoundError: No module named 'wx.siplib'

Looks like another missing Requires. The python dep generator should've caught this. Checking now.

Looks like another missing Requires. The python dep generator should've caught this. Checking now.

Thanks! I've tried finding the right package with wx but was not sure, which one is the missing one.

It's a combination of things:

  • we should use wxpython4
  • upstream wxpython bundles sip, but the package in fedora unbundles it

So, we've got to patch fsleyes to use the system version of wxpython4 and the system version of sip :D

I also see that upstream has an unecessary limit on the version of Pillow, which I've also patched out. Testing builds now. Hopefully these are all the fixes that are needed.

That's interesting. I didn't think it would be so difficult to make it work...;-)

That's interesting. I didn't think it would be so difficult to make it work...;-)

Yeh. It shouldn't be, but then upstreams do weird things and we figure them out one by one XD

We were already using wxpython4, but we hadn't patched fsleyes to use the system version of sip. Koji is chugging away at a new build now. :pray:

This build functions correctly now: https://koji.fedoraproject.org/koji/taskinfo?taskID=31144134

Pushing another update :D

I am testing fsleyes and I was wondering what $FSLDIR will be set to by the main fsl package.

Yes, that must be set by FSL. This can be disabled, but I'd rather leave it in so users know this is required.

https://github.com/pauldmccarthy/fsleyes/issues/8

Not in testing any more. Merely waiting for other optional requirements to be packaged.

Metadata Update from @ankursinha:
- Issue untagged with: S: In testing

2 months ago

Login to comment on this ticket.