modularity / fedmod

#78 Add rpm2flatpak and flatpak-report subcommands
Closed by nphilipp. Opened by otaylor.
modularity/ otaylor/fedmod flatpak-generator  into  master

Download 78.patch

This PR adds new subcommands:

rpm2flatpak generates an appropriate modulemd file and container.yaml (for OSBS) file to package up a RPM of a graphical application with dependencies as a Flatpak.

flatpak-report is a specialized subcommand that basically is just used in the scripts for maintaining the flatpak-runtime module - the idea is that you pass in a list of RPMs and it creates a report that shows what packages from the runtime and what additional packages are needed if you ran rpm2flatpak on all the RPMs one-by-one. But it's much faster than doing that, and also, the rpm2flatpak output doesn't actually include information about what required rpms are satisfied by the runtime - something we want when maintaining the runtime to see if packages that we put in the runtime are actually required by lots of different applications.

Note that this will need to be rebased after #77 is merged (or vice-versa) to fix a test failure because the expected summary/description will change. The patch can be independently reviewed, however.

pdc is dead..

Well, it's still operational in Fedora, but yeah, removing PDC usage from
here got lost on my to-do list. I'll redo that part of the patch to use the
mbs API later and see how it goes.

(Getting flatpak-runtime added to the modular updates composes also
possible, then the flatpak-runtime modulemd could just be read from there,
but it's a bit questionable since a user would never want to enable that
module.)

On Wed, May 16, 2018, 1:20 PM Igor Gnatenko pagure@pagure.io wrote:

ignatenkobrain commented on the pull-request: Add rpm2flatpak and flatpak-report subcommands that you are following:
pdc is dead..

To reply, visit the link below or just reply to this email
https://pagure.io/modularity/fedmod/pull-request/78

rebased onto 2ed3edd4eda6390e6a18debf80c6adee80c573e8

Pushed a new PDC-free version that talks to Koji instead.

rebased onto 3b89033f18dcaf31516de97c5ec8e788d6515923

return rpm_name.rsplit("-", 2)[0]

rebased onto 2ffa2f226d0179796f733adcbb79aab693c45a39

I pushed a new rebased version that also:

  • Cleans up the _name_only utility function that was cut-and-pasted into multiple files
  • Switches to a more-evolved version of my koji querying code (See https://lists.fedorahosted.org/archives/list/infrastructure@lists.fedoraproject.org/thread/C7PZPQVRKLQ3PPKD726YR5K2EMYQUZQ5/ for the question of where this should live long-term.)

Any chance of getting this reviewed and merged?

Took me a while because we discussed going from "one tool with many verbs" to "one library plus multiple tools" which would make enhancements like this one easier (new tools like this one wouldn't need to go through a PR to be accepted into the "core).

I'll rebase/merge for now, we can make this its own command when that change happens.

applied in commit 0033a514f125fc6ca4f77e6a725271ea381e2227

Pull-Request has been closed by nphilipp
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.