#69 Update for F28 branched
Merged by karsten. Opened by otaylor.
modularity/ otaylor/fedmod f28-branched  into  master

Download 69.patch

Here's a basic set of patches that get fedmod working again on top of F28 branched and the modular repository. Module generation is considerably simplified with hybrid modularity.

  • Components in the rpm2flatpak output are only the srpms for the packages listed on the command line
  • Module requires and buildrequires are a) modules containing packages required by the packages on the command line b) platform

Some more fine-tuning is necessary - fedmod doesn't have any handling for modules with multiple streams - like we have with nodejs. And probably if a package is available both in the base package set and in modules the default should be to just use the package in the base package set, which is the opposite of what happens here.

But this gets things to the point where fedmod runs and the tests pass and should be a good basis for further work.

6 new commits added

  • Strip down module generation
  • Comment out references to updates repo
  • Move from F27 to F28
  • Remove special handling of fedora-release
  • Remove references to bootstrap module
  • Move gzip import into the right file

LGTM with one exception
The output of 'fedmod rpm2module' is still spec_v1, we need spec_v2:
https://github.com/fedora-modularity/libmodulemd/blob/master/spec.v2.yaml

I'll go ahead and merge this anyway

Pull-Request has been merged by karsten

https://pagure.io/modularity/fedmod/issue/71 is for the spec_v2 changes

Metadata