#68 When tracking package dependencies, look at pre-requires, not just normal reqs
Merged by karsten. Opened by otaylor.
modularity/ otaylor/fedmod all-requires  into  master

Download 68.patch

package.lookup_deparray(solv.SOLVABLE_REQUIRES) only returns normal Requires:,
to get pre-requires, you need to pass in marker=1 (default is marker=-1)

Looks good to me, although I'd wish there was a way to disable the new behaviour with a commandline switch

Are you confusing pre-requires with recommends? I don't see a use case for
disabling only those requirements that are supposed to be installed before
the package.

On Tue, Apr 3, 2018, 7:01 AM Karsten Hopp pagure@pagure.io wrote:

karsten commented on the pull-request: When tracking package dependencies, look at pre-requires, not just normal reqs that you are
following:
Looks good to me, although I'd wish there was a way to disable the new behaviour with a commandline switch

To reply, visit the link below or just reply to this email
https://pagure.io/modularity/fedmod/pull-request/68

I don't think I've confused pre-requires and recommendations. I was only concerned about the changed behaviour where it now finds more requirements. After giving this a second thought, I think you're right. We need those new packages anyway to be able to install a given rpm, it is just a matter of when exactly those packages are required.

Pull-Request has been merged by karsten

Metadata