modularity / fedmod

#113 Support rpm2flatpak for RHEL Flatpaks
Merged by kalev. Opened by tpopela.
modularity/ tpopela/fedmod support-rhel-flatpaks  into  master

Download 113.patch

In case we detect that we're using the RHEL Flatpak Runtime, we have to
switch the koji profile to brew so we're communicating with the right
build server.

Hm, this feels like a wrong place to put this.

I wonder if it would be better to put it in fedmod configuration file instead, so that the el dataset would get an extra koji-profile=brew line?

Yes, that will be definitely better. I will rework the patch.

rebased onto 6ba9471d52b7b85505b111d9e990817c76766d6a

rebased onto e83e5dfe750b40483ca8f32108ff1483b5585157

I am not sure what's going on here and maybe I'm missing something obvious :)

I see two chunks in the latest version and they are both parsing the config, but reading different keywords. The first chunk (flatpak_generator.py) reads the 'koji-profile' keyword and the second one (get_module_builds.py) reads 'buildsystems: koji: profile' keyword. Why two different keywords? Is one of them a leftover from an earlier attempt?

rebased onto 1901bfd88032b12a74d2a711b7372e961cc68bfe

Exactly as you've said. The first one is a leftover after I've identified a better place for the profile to be stored in - "buildsystems: koji: profile".

Sorry about it.

Okay! Looks good to me now. Thanks!

Pull-Request has been merged by kalev
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.