#107 Fix regex in flatpak_generator.py
Merged by kalev. Opened by xberry.
modularity/ xberry/fedmod master  into  master

Download 107.patch

Original regex just matched multiline C-like comments and did
mistakes when sometimes matched filesystem
wildcard "" (eg. in /usr/lib/.so) as a start of the comment.

New regex forbids nested comments (which are forbidden in C as well)
which also solves the problem above (no trailing */ found -> no match).

There still are some extremely improbable situations when this regex
(as well as the old one) fails (like /usr//app-version/), though.

Can you remove the trailing space here please? Git complains.

Looks good to me - just a tiny nit above. Thanks for looking into this!

rebased onto 7ec02f1dc78524b1f9ae5634b9ca63ccf97d2739

Trailing space fixed. I also rebased and slightly edited commit message to follow the same pattern as the previous ones.

Thanks! Looks good to me!

(Can you CC me if you have any other fedmod fixes? I can merge things here but aren't CC'd by default it seems.)

Pull-Request has been merged by kalev

Thanks for merging!

(Sure, I'll CC you next time.)

Metadata