People are often confused by "Ready" meaning - they expect that builder is down. Maybe we could extend the channel page (maybe also hosts/hostinfo) with something more self-explaining. ("running/live" field (based on last checkin) or number of active tasks there?)
Do you mean on the hostinfo page?
Metadata Update from @mikem: - Custom field Size adjusted to None
I suppose we could invert the sense of the word. Perhaps:
not(ready)
Alternately, collapse the two columns into a single status.
(plus still include helpful info in mouseover text and perhaps a docs link somewhere)
Metadata Update from @jlibrova: - Issue set to the milestone: 1.37
What about another state - "not ready and have not checked in for some interval (e.g. sleeptime * 2), so we can expect that builder is dead"?
red - "disabled"
I would vote for - disabled as gray - "have not checked in for some interval" as Error / Problematic / Offline and some info of no response time somewhere like mouseover text?
"not ready and have not checked in for some interval"
Ah, I was thinking similarly before. I left my initial notion out because the scheduler will automatically mark hosts not-ready after a timeout, but it would be good to distinguish the stale hosts from the merely busy.
The config for this is maybe a little tricky. We already have the ready_timeout setting on the hub, but the web can't see that, and each host has their sleeptime setting, but that is only known on the host. I guess as a first pass, we can duplicate the the ready_timeout setting in the webui. Alternately, we can add new data into the host table to let the scheduler mark this.
disabled as gray
ah good point. disabled is a normal situation and should not be alarming.
So I guess we're at
Just a reminder that many people in the world have various red/green color blindness, so if you do use colors, you should also use a icon or other indicator too.
Just a reminder that many people in the world have various red/green color blindness
Ah, very good point.
Text colors will be set in css class of course, though we currently just have images in these columns. Internally, the images are selected via the imageTag function which works with the theme config.
imageTag
I think we already have some sensible theme images and css classes to use here for most cases. E.g.
ready.png
building.png
failed.png
deleted
expired
canceled
Metadata Update from @jlibrova: - Issue assigned to jlibrova
PR 4551
Metadata Update from @mfilip: - Issue tagged with: testing-basic
Metadata Update from @tkopecek: - Issue tagged with: testing-ready
After looking at the current PR in the browser, a couple things jumped out at me:
What do folks think here?
Metadata Update from @mikem: - Issue untagged with: testing-ready
OTOH, since handling the simulated state in PR #4551 is proving to be a little messy, perhaps this something like the alternate approach from my earlier comment. I.e.
Metadata Update from @jlibrova: - Issue untagged with: testing-basic
This issue has been migrated to Fedora Forge: https://forge.fedoraproject.org/koji/koji/issues/4549
Please continue any further discussion there.