Should we lump this together with other removals of the old ca option? We have the same option in the cli, and in various config files. There are even still docs references.

You say it's deprecated, but passing the option to the command does not print any deprecation warning. The only indication I see is that the help text says "ignored". It certainly hasn't been a relevant option in a long time, but I don't think as a user that I'd read that is "this option is going away".

I'm always cautious about changes that could cause a formerly valid setup to become invalid.

I like the idea of removing the "ca" option completely from the CLI arguments + profile settings + docs in one go.

I understand why we'd want to print deprecation warnings to users first. One of Koji's keys to success is its stability over the years.

I like the deprecation warning we've added to krb_login() in PR #1992. Is there any central place we could put a similar warning for the "ca" option?

It is used only in these two places (cli + gc). I think, it is ok to put deprecation warning to these two files after config + options parsing if ca is populated and plan final removal to 1.24.

PR #2226

Commit a2d80c5 fixes this issue

Commit 0e5b54f fixes this issue

trivial fix #2246 for the warning of cli --ca option

Commit 743c3bd fixes this issue

Commit 80cf5ac fixes this issue

Hi,
This will have impact on RPMFusion , RPMfusion users still use certificates to upload source and do builds on koji .
I don't see any reason to change .

Hi,
This will have impact on RPMFusion , RPMfusion users still use certificates to upload source and do builds on koji .
I don't see any reason to change .

That option is not used for anything for many versions. It is just about removing it from configuration files.

/usr/lib/python3.7/site-packages/koji/util.py:65: DeprecationWarning: ca option in config file is deprecated and will be removed in 1.24
warnings.warn(message, DeprecationWarning)

milestone shouldn't be 1.24 ?

Yes, iti is (https://pagure.io/koji/issue/2192) - but when I'm adding comment here, pagure due to bug resets milestone for this closed issue.

@sergiomb we should remove the ca option from RPM Fusion's Koji client settings.

From #koji a few days ago:

< ktdreyer> kwizart: the "ca" option was basically unused on the client, 
            so that is why we're removing it
< ktdreyer> kwizart: when users connect with "~/.rpmfusion.cert", it 
            should "just work" without specifying "ca = 
            ~/.rpmfusion-upload-ca.cert" client-side
< kwizart> ktdreyer, okay, so it's ca that is deprecated, not serverca
< ktdreyer> exactly

Specifically you can delete the ca = ~/.rpmfusion-upload-ca.cert line at https://github.com/rpmfusion-infra/rpmfusion-packager/blob/master/configs/rpmfusion.conf