PR#2246: deprecated warning for cli option --ca as well - koji

koji

#2246 deprecated warning for cli option --ca as well

Merged 3 years ago by tkopecek. Opened 3 years ago by julian8628.

julian8628/koji fix-issue-2182 into master

warning for both cli and config file option

Yu Ming Zhu • 3 years ago

5ce2418

deprecated warning for cli option --ca as well

Yu Ming Zhu • 3 years ago

9910ec0

cli/koji

file modified

		`@@ -150,6 +150,9 @@`
		`help=_("list commands"))`
		`(options, args) = parser.parse_args()`

		`+ if options.ca:`
		`+ koji.util.deprecated("--ca option is deprecated and will be removed in 1.24")`
		`+`
		`# load local config`
		`try:`
		`result = koji.read_config(options.profile, user_config=options.configFile)`

koji/__init__.py

file modified

+1 -1

		`@@ -1915,7 +1915,7 @@`
		`result[name] = os.path.expanduser(result[name])`

		`if result.get('ca'):`
		`- util.deprecated("--ca option is deprecated and will be removed in 1.24")`
		`+ util.deprecated("ca option in config file is deprecated and will be removed in 1.24")`

		`return result`

julian8628 commented 3 years ago

fixes: #2182

Metadata Update from @julian8628:
- Pull-request tagged with: testing-ready

3 years ago

tkopecek commented 3 years ago

What is the problem here? It works for me without this change?

tkopecek commented 3 years ago

I'm not losing that message for other tools/configs.

julian8628 commented 3 years ago

if executing koji --ca abc hello, because the old code only checks the config result from config file, if there's no ca option in koji profile, the msg won't be shown.