#468 Make product_versions optional in gating.yaml
Closed: Fixed 5 years ago by vmaljulin. Opened 5 years ago by lholecek.

Any reason for product_versions to be required in gating.yaml?

It seems that, if the value is empty in gating.yaml, it can be simply inherited from the policy in Greenwave configuration which contains the the RemoteRule.


I guess we can do that.

Isn't that needed to check if the policy matches? We should check that, if it's not useful we can do that, so that gating.yaml would be simplified.

The parent policy (defined in Greenwave configuration, containing the RemoteRule) can contain product_versions, which Greenwave already checks. It can be omitted in gating.yaml, so Greenwave doesn't have to check the product version again (basically, the default value here would be [*]).

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #518 Merged 5 years ago