#654 [getfedora.org] make the key modal larger to prevent overflow
Merged 2 years ago by robyduck. Opened 2 years ago by ryanlerch.
ryanlerch/fedora-websites wide-keys  into  master

@@ -30,7 +30,7 @@ 

               role="dialog"

               aria-labelledby="${shortid}-label"

               aria-hidden="true">

-           <div class="modal-dialog">

+           <div class="modal-dialog modal-lg">

              <div class="modal-content">

                <div class="modal-header">

                  <button type="button" class="close" data-dismiss="modal">

previously the modal that we present to show the keys for
a release in getfedora.org/keys sometimes overflowed if the
UID was longer. This makes the modal a modal-lg to prevent this

fixes: #539

Does this fit also on mobile? If not we need to write an extra mobile code line to get it fixed properly.

The existing way didnt work on mobile either. Will need to do some further work to get it mobile friendly though. The table that is used in this modal is not very mobile friendly.

Oh, right :(
FWIW making this mobile friendly is probably a mess anyway, as we will need to split the key or make it so small that it will probably become unreadable.

yeah, i think trying to make this mobile friendly is a much bigger task.

can i just merge this one to fix the initial issue?

Pull-Request has been merged by robyduck

2 years ago
Metadata