#1153 Contributor Survey Banner
Closed a month ago by darknao. Opened 2 months ago by lilyx.
lilyx/fedora-websites main  into  main

@@ -4,17 +4,22 @@ 

    xmlns:py="http://genshi.edgewall.org/"

    xmlns:xi="http://www.w3.org/2001/XInclude"

    py:strip="">

-     <div class="col-xs-12 col-sm-4 bluebox border">

+     <div class="col-xs-12 col-sm-3 bluebox border">

        <div class="text-center">

          <h3><a href="https://docs.fedoraproject.org/" alt="Fedora Docs"><i class="fa fa-fw fa-book header-icon"></i>${_('Fedora Documentation')}</a></h3>

        </div>

      </div>

-     <div class="col-xs-12 col-sm-4 bluebox border">

+     <div class="col-xs-12 col-sm-3 bluebox border">

+       <a href="https://fedoraproject.limequery.com/2022">

+         <img src="${path}/static/images/contributor-survey-banner.png" alt="Contributor survey banner" />

+       </a>

+     </div>

+     <div class="col-xs-12 col-sm-3 bluebox border">

        <div class="text-center">

          <h3><a href="https://ask.fedoraproject.org/" alt="Ask Fedora"><i class="fa fa-fw fa-question-circle header-icon"></i>${_('Help for Fedora Users')}</a></h3>

        </div>

      </div>

-     <div class="col-xs-12 col-sm-4 bluebox border">

+     <div class="col-xs-12 col-sm-3 bluebox border">

        <div class="text-center">

          <h3><a href="https://getfedora.org" alt="Get Fedora"><i class="fa fa-fw fa-download header-icon"></i>${_('Get Fedora')}</a></h3>

        </div>

I've added the 2022 survey banner

So the img tag needs to be closed as we are in XHTML mode, and there is a

missing at the end.
Can you make the changes?

1 new commit added

  • fixed html syntax errors
2 months ago

rebased onto 5785f89de8066e7e042d6d0ebd8a00bd4b1313cf

2 months ago

Sorry I didn't catch that one the first time, but the path should be ${path}/static/images/contributor-survey-banner.png.
The ${path} variable will then be substituted to the correct base path depending on the target environment (which is / in production).

The class img-fluid is also not defined anywhere.

1 new commit added

  • added /home/redhat/.nvm/versions/node/v16.15.0/bin /usr/lib64/ccache /usr/local/bin /usr/local/sbin /usr/bin /usr/sbin to img and removed img-fluid class
2 months ago

That's super weird... that is not a file that was edited or relevant to this PR and wasn't touched by git. I'm not sure how to explain what's in that commit there. However in the actual files changed, I added ${path}. I'm not sure about the img-fluid thing, that's a normal bootstrap class that is in version 4.

rebased onto 3e4e476

2 months ago

This website still use bootstrap 3.0.3 ... :/

I don't see any irrelevant files in this PR, so I guess it's only the commit message that got messed up somehow, nothing to worry about.

I guess it needs some styling to replace the missing img-fluid class.

You can check the latest preview here if that helps: https://pr1153-fedora-web-ci.apps.ocp.ci.centos.org/start.fedoraproject.org/

Hey @lilyx, do you need any help going further on this PR?
I can merge it and try to figure out the missing css styling on the banner if you want me to.

Closing as not needed anymore

Pull-Request has been closed by darknao

a month ago