#567 Use https for fedoramagazine links
Closed: Fixed None Opened 8 years ago by robyduck.

The https is now setup correctly for fedoramagazine.org. We should update all our links to https too (use double slash).

Links are in all footers, the main getfedora index and some other places I think.


I wish to work on this, but which links are to be changed to https:// ?
thanks :)

The bestwould be to do a grep through all websites (getfedora, labs, spins, ARM) and substitute the http://fedoramagazine.org link with //fedoramagazine.org.

You can also use sed for this, but check out the result before filing the patch.

Thanks.

Has it been fixed? If not I'd like to work on it. Thanks :)

Feel free to take it and add your patch here. Thank you.

d1indra, any updates here?

robyduck, Shall I work on this ?
Can you point me to the source repo for this ticket ?

Sure, it's all in our websites repo: https://git.fedorahosted.org/git/fedora-web.git

Please take a look on our wiki page to learn how to clone the repo and file patches:
https://fedoraproject.org/wiki/Websites

Thanks ;)

Robyduck Hi,

I have fixed the ticket and attached the patch file here : [https://fedorahosted.org/fedora-websites/attachment/ticket/361/0001-Fixes-ticket-361.patch]

Let me know if any changes required. :)

Looks good. Can we use {{{//fedoramagazine.org}}}

instead of using https:// ?

Nice, but you have trailing white spaces in the patch. There is a whitespace before a tab indent, if you want fix it, otherwise I can do it also after applying your patch.

Thanks.

Ok applied. Thank you. I fixed the whitespace afterwards, no worries.

Login to comment on this ticket.

Metadata