We should do something about http://validator.w3.org/check?uri=fedoraproject.org&charset=%28detect+automatically%29&doctype=Inline&group=0
There are at least lots of small errors.
Checking CSS would probably be to much work, but if someone want to do it…
Cleaned up formatting.. Was missing a couple end tags and all bunched up. This one is easier to read. Also separated the font-size and font family attributes so it validates properly with JigSaw text.css
Apparently we missed this patch, thanks to you. Gonna check later today or this week.
This is not a patch and will take more time to verify. Next time please see http://fedoraproject.org/wiki/How_to_fix_bugs_on_the_Fedora_Project_website
Many thanks,
I'll take a look at this. Only a few errors, should be a simple fix.
I'm working on this. First, I will test that patch above then fix another issues if I'll encounter them.
I pushed it into f20 branch yesterday so I'll close it. Feel free to reopen if you're not satisfied.
Reopening because I reverted the commit. It breaks our layout and doesn't work as it should. Let's test it a bit more before reapplying it.
I want to work on this, Please assign it to me.
I checked this patch a bit with JS enabled and disabled and it's working fine for the end-user.
Re-validating the pages with a W3C validator still gives me some errors, mainly in the get-fedora page. For now I'm not pushing this patch forward into production, maybe you can review it a bit and see if it can be improved.
Thank you very much for your effort.
Second patch for validating according to w3c validator. 0001-Validated-website-with-w3c-validator.patch
Hi Sheeshmohsin,
How did you "generate" it?
I tried with {{{ git apply }}} command but there are some warnings.
{{{ $ git apply 0001-Validated-website-with-w3c-validator.patch 0001-Validated-website-with-w3c-validator.patch:557: trailing whitespace.
0001-Validated-website-with-w3c-validator.patch:929: trailing whitespace.
0001-Validated-website-with-w3c-validator.patch:941: trailing whitespace.
0001-Validated-website-with-w3c-validator.patch:953: trailing whitespace.
0001-Validated-website-with-w3c-validator.patch:965: trailing whitespace.
warning: squelched 6 whitespace errors warning: 11 lines add whitespace errors. }}}
Anyway, I viewed it and looks good to me.
OK, it will be fine. We can ignore those warnings, I'll commit it soon.
I just followed the steps in this link to generate the patch :- http://fedoraproject.org/wiki/How_to_fix_bugs_on_the_Fedora_Project_website
[https://git.fedorahosted.org/cgit/fedora-web.git/commit/?id=ae55154698f8eb245dd7fb07f91cd7588d67db3e Commited].