#112 coreos-download: restyling coreos download page
Merged by dustymabe. Opened by abai.
fedora-web/ abai/websites coreos-download  into  master

Download 112.patch

Restyles the Fedora CoreOS Download page based on the initial proposed
design https://pagure.io/fedora-websites/issue/964#comment-576026.

Moreover, dustymabe and abai thought it could be a good idea to add release
stream info and release notes to the top level coreos page:
https://getfedora.org/en/coreos/.

Signed-off-by: Allen Bai abai@redhat.com

rebased onto 2824dd3d0cb52fd2a64d42423b0e13b5fb017c13

1 new commit added

  • coreos-download: add release note section

Adds a release note section on the overview page of Fedora CoreOS Download. This gives users general information about the last 5 releases for each of stable, testing and next stream.

For each release, list the versions of important packages and package information about what was added, removed, upgraded and downgraded. In addition, for future improvements, adding notes on bugfix information might also be helpful.

Demo:
gif demo

Overview page:
image demo overview page

Download page:
image demo download page

Cleaning up the code and adding comments in coreos-download.js tomorrow and will remove the [WIP] after the cleanup.

Is there anything else we should be adding right now? I think bugfix information would be very helpful/informative in the future, but I'm assuming that would require extra maintenance effort for each release..

cc @dustymabe @jlebon

we probably don't want to link users directly to https://builds.coreos.fedoraproject.org/browser - it's not an official app we want people to rely on

The mockups look grat abai. We did discuss maybe for now (until we get proper release notes) we keep the package diff but make it less prominent. So for example we have a summary and make each of them clickable. For example in the release notes we highlight the primary packages we care about but then say:

478 packages (50 upgraded, 2 added, 3 removed)

and have the 478 packages link show the full package list for that revision and the 50 upgraded, 2 added, 3 removed show the package diff from the previous release. WDYT?

1 new commit added

  • coreos-download: use releases instead of builds for release note

@dustymabe sorry for delayed reply but yes I'm working towards that and the new commit already commented out the direct links for the FCOS release browser. Been working on getting the accumulated pkgdiff between releases working given a list of builds and just pushed a commit to address it.
Now I'm working on get the pkg summary like you mentioned in the previous comment. ;) This feature should be rolled out quickly.

1 new commit added

  • coreos-download: add summary for packages and pkgdiffs

4 new commits added

  • coreos-download: add summary for packages and pkgdiffs
  • coreos-download: use releases instead of builds for release note
  • coreos-download: add release note section
  • coreos-download: restyling coreos download page

Overview page:
overview page

Download page:
download page

GIf demo:
gif demo

Ready for another look. The pkgdiffs and builds shown on the page are now all releases and accumulated pkgdiffs between releases are computed from the intermediate builds pkgdiffs.

cc @dustymabe @jlebon

rebased onto 4682c25b46996313b2c1fc858d9d4c2a29ed98e4

Rebased on the master branch

The renderings look great! I'm no js expert so my review on the code isn't worth much. Only question I have is if we want to leave that one section commented out. Do we have plans for it in the future?

@dustymabe The section commented out is for the four buttons linked to the releases browser, which we earlier decided to not expose to public (loudly).. The buttons come from the initial design but I cannot think of other places I can link to at the moment.

Pulled the PR and ran it locally successfully!

Not familiar with JS enough to give a technical review on the code, but it WFM!

LGTM

1 new commit added

  • coreos-download: add buttons for releases in download page

Added a final touch that exposes the buttons back to the download page but instead of linking to release browser, the buttons are linked corresponding release notes. And also added URL parameter stream in the release notes like in the download page. For example, now users can view the testing stream release notes via https://getfedora.org/en/coreos?stream=testing.

let's 🚢

Pull-Request has been merged by dustymabe

Metadata