PR#212: discussions: fix configurable BBA URL in ticket description - fedora-qa/blockerbugs

fedora-qa / blockerbugs

#212 discussions: fix configurable BBA URL in ticket description

Merged 3 years ago by kparal. Opened 3 years ago by kparal.

bug/stglinks-192 into develop

discussions: fix configurable BBA URL in ticket description

Kamil Páral • 3 years ago

0aec84e

blockerbugs/config.py

file modified

+2 -2

		`@@ -66,7 +66,7 @@`
		`PAGURE_DISCUSSION_TITLE = "[$component] $summary \| rhbz#$bugid"`
		`PAGURE_DISCUSSION_CONTENT = '''\`
		`Bug details: $bug_url `
		`- Information from [BlockerBugs App]({}):`
		`+ Information from [BlockerBugs App]($blockerbugs_url):`
		`![$bugid]($bug_img)`
		`#### Current vote summary`
		`$vote_summary`
		`@@ -76,7 +76,7 @@`
		A quick example: `BetaBlocker +1` (where the tracker name is one of \
		`BetaBlocker`/`FinalBlocker`/`BetaFE`/`FinalFE`/`0Day`/`PreviousRelease` \
		and the vote is one of `+1`/`0`/`-1`)
		`- '''.format(BLOCKERBUGS_URL)`
		`+ '''`


		`class ProductionConfig(Config):`

blockerbugs/util/pagure_interface.py

file modified

		`@@ -149,6 +149,7 @@`

		`def render_discussion_template(template, bug, vote_summary='Nobody voted yet.'):`
		`rendered = Template(template).substitute(`
		`+ blockerbugs_url=app.config['BLOCKERBUGS_URL'],`
		`bug_img=f"{app.config['BLOCKERBUGS_API']}bugimg/{bug.bugid}",`
		`bug_url=bug.url,`
		`bugid=bug.bugid,`

kparal commented 3 years ago

The URL was supposed to be configurable, but wasn't, because the URL was baked
into the ticket template during initial startup and the BLOCKERBUGS_URL config
option no longer affected it. This fixes it.