#6802 HYPERKITTY does not show what posting text is being addressed in a reply.
Closed: Upstream 3 years ago Opened 4 years ago by bier.

In a recent Fedora users list thread "alternative to skype":
"https://lists.fedoraproject.org/archives/list/users@lists.fedoraproject.org/thread/4PYAEGBJY4XPBDCZPHWVNS5DWISTMCNO/",
one member commented
"Don't quote the entire email. In fact, don't quote anything at all when you reply. On k-9 mail there's a little x button (in the default config) that I can click to get rid of all the quotes text."
Another responded on March 25:
"No, do quote the part you are commenting on. It makes no sense to omit this. Of course it's all there in the archives but making your readers open a browser just to get the context of what you are talking about is poor practice. I note that posts via HyperKitty seem to do this but don't know if that's the way it works by default. If so it's a bug and should be fixed."
I myself have experienced what the second member said, and I agree with him. List members respond to my posts in parts, but I have trouble knowing what specific part of my post the member is responding to.

I don't know if this is a requirements bug, design bug, or implementation bug, but I do believe it's a bug. I don't know if the problem is in HYPERKITTY or something "upstream".


I am not sure what you are asking for here. Can you clarify?

When you reply to a post via hyperkitty, there is a 'quote' button that automatically quotes the email you are replying to into your editor window. You can then add comments after particular parts you want to reply to and delete parts you don't. This is pretty standard in a mail client.

Can you explain what you are doing and what happens and what you expect to happen?

I'm not sure what the OP is asking either.

However, it seems HyperKitty improperly quotes nested replies.

In the message below "chicago" has sent a message to which "poc" has replied. I'm attempting to reply to "poc" and use quote. Their is no indication that "poc" has said anything.

It should look like what Thunderbird does.

kitty-quote.jpeg

tb-quote.jpeg

Kevin,

I am not sure what you are asking for here. Can you clarify?
Ed (egreshko) said it well; his attachments show it well. (Thank-you, Ed!)

In a reply to a post, HYPERKITTY often shows a vertical line followed by 3 dots ("|...) for the text being replied to. Perhaps the list member used an e-mail client (Thunderbird, evolution, gmail's browser interface, etc.) to reply. It's difficult to know what text in a posting a reply is responding to when all the reader sees is "|...". In HYPERKITTY, I'd like to see the text being replied to rather than "|...". In Ed's first attachment, Patrick's reply to chicago's message is how I want it to look. Chicago's reply to my post is how I don't want it to look.

I often use HYPERKITTY rather than an e-mail client to post things and to reply to posts. I use a yahoo account as my Fedora users list login. I've seen several complaints that such posts done via HYPERKITTY are not showing up in digests or e-mail messages. Ed's second attachment show an example of this, too! Patrick never saw the post that Chicago replied to. Is this problem occurring because a poster's Fedora list account is based on a yahoo account, or because the member used HYPERKITTY to post? If I should open a separate issue on this, please let me know and I'll do so.

thanks,
Bill.

In a reply to a post, HYPERKITTY often shows a vertical line followed by 3 dots ("|...) for the text being replied to. Perhaps the list member used an e-mail client (Thunderbird, evolution, gmail's browser interface, etc.) to reply. It's difficult to know what text in a posting a reply is responding to when all the reader sees is "|...". In HYPERKITTY, I'd like to see the text being replied to rather than "|...". In Ed's first attachment, Patrick's reply to chicago's message is how I want it to look. Chicago's reply to my post is how I don't want it to look.

You do realize you can click on the |... and expand the quoted section? It's just collapsed by default.
So, you would prefer it to be expanded by default? Or be a preference for your account?
That sounds like a good request to make of upstream. Would you be willing to file this request there or if you like I can do so... https://gitlab.com/mailman/hyperkitty/

I often use HYPERKITTY rather than an e-mail client to post things and to reply to posts. I use a yahoo account as my Fedora users list login. I've seen several complaints that such posts done via HYPERKITTY are not showing up in digests or e-mail messages. Ed's second attachment show an example of this, too! Patrick never saw the post that Chicago replied to. Is this problem occurring because a poster's Fedora list account is based on a yahoo account, or because the member used HYPERKITTY to post? If I should open a separate issue on this, please let me know and I'll do so.

That issue has nothing to do with hyperkitty, it has to do with your using a yahoo.com account.
See for example: https://www.pcworld.com/article/2141120/yahoo-email-antispoofing-policy-breaks-mailing-lists.html

I would strongly advise you to switch to another provider. Folks using google/gmail or many other services will never get your posts to mailing lists while you are using a yahoo.com return address. ;(

The quoting issue appears to be that hyperkitty simply doesn't include any attribution of the quoted text. Adding it would require a patch to the javascript. I think something like this (though it's likely buggy due to my lack of strong javascript abilities):

diff --git i/hyperkitty/static/hyperkitty/js/hyperkitty-thread.js w/hyperkitty/static/hyperkitty/js/hyperkitty-thread.js
index bd17e98..f5118c2 100644
--- i/hyperkitty/static/hyperkitty/js/hyperkitty-thread.js
+++ w/hyperkitty/static/hyperkitty/js/hyperkitty-thread.js
@@ -252,10 +252,13 @@ function setup_replies() {
         if (sig_index != -1) {
             quoted = quoted.substr(0, sig_index);
         }
+        // set reply attribution
+        var attribution = $(this).parents(".email").first()
+                            .find(".email-body").clone().text() + ' wrote:';
         // add quotation marks
         quoted = $.trim(quoted).replace(/^/mg, "> ");
         // insert before any previous text
-        textarea.val(quoted + "\n" + textarea.val());
+        textarea.val(attribution + "\n" + quoted + "\n" + textarea.val());
         textarea.focus();
     });
     function set_new_thread(checkbox) {

If someone wants to test that properly and submit it as a proper patch either against the Fedora install or, ideally, upstream hyperkitty, it would be great.

You do realize you can click on the |... and expand the quoted section?
I did not.
I do now.
So I tried it. I like it!
Thank-you, Kevin.

So, you would prefer it to be expanded by default? Or be a preference for your account?
I notice that the Fedora users list has 126 members. I think the question should be posed in a post there to get input from as many as are willing to give it. My preference: weakly favoring not expanded by default. Account preference: good idea.

That sounds like a good request to make of upstream. Would you be willing to file this
request there or if you like I can do so... https://gitlab.com/mailman/hyperkitty/
As was evident in my submission of this issue, I don't write bugs, issues, etc. well. I think it's best to let you do the submission.

Lately, I see a fair amount of criticism of HYPERKITTY. Though not perfect, I like HYPERKITTY overall more than the older archive, and more than using separate e-mail clients. I do still need the e-mails in case someone posts to a thread that was closed weeks ago.

Bill.

Ed Greshko's comments in his March 27 at 4:53pm (mountain time?) reply to Kevin are correct. When B replies to A, and C replies to B, only B's text shows when the "|..." is expanded. Also, that expanded text is attributed to A, not B. This can be confusing.

C's post should show "|..." (or expanded text) for each part B's text that C is responding to, and that text should be attributed to B, not A. When one of those "|..." is expanded, that expanded text should show "|..." for each part of A's post that B responded to, and that text should be attributed to A.

My apologies if this isn't clear. Recursive requirements are difficult to write clearly! Last time I tried doing recursion, I would up cursing, and recursing! :-)

Bill.

@abompard can you take a look here and see if upstream would take this change?

Metadata Update from @kevin:
- Issue tagged with: lists

4 years ago

Metadata Update from @kevin:
- Issue assigned to abompard
- Issue priority set to: Waiting on Asignee

4 years ago

OK, it was a bit more complex but I think I fixed it with this commit:
https://gitlab.com/mailman/hyperkitty/commit/755868220db1e72135ea2b9b9ef8ba72b77ce147

I don't have a deployment plan for Fedora infra prod yet but it will have to wait after the freeze anyway.

This should land in our instance the next time we upgrade from upstream... going to go ahead and close it here.

Metadata Update from @kevin:
- Issue close_status updated to: Upstream
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Attachments 2
Attached 4 years ago View Comment
Attached 4 years ago View Comment