This is setup in:

roles/distgit/files/setup_git_package

which needs to learn about namespaces. ;)

Do we want to have aliases for each owner(s) in each namespace?
ie, docker-cockpit-owner, rpm-cockpit-owner, etc.

Do we want to have aliases for each owner(s) in each namespace? ie, docker-cockpit-owner, rpm-cockpit-owner, etc.

I think this would make sense, container-cockpit-owner, modules-cockpit-owner
Maybe just not for the rpms namespace since this alias has been there for a long time (or we have both <pkg>-owner and rpms-<pkg>-owner).

Should we make this an easyfix?

Sure. Note that the alias change has to happen in fas2. Would you care to file a bug there or shall I?

Otherwise yeah, this should be easyfix hopefully...

So a bit more background here:

When a new rpm package, container, module, etc are added the roles/distgit/files/setup_git_package script is run to set them up. It adds a 'mailing-list' field there that is a way to mail the people involved in that thing. It works as expected/desired for new rpm packages, but it doesn't for the other things we now have.

We now have:

container
docker
modules
rpms
test-docker
test-modules
test-rpms

This might be as simple as making sure the / is changed to a -
(ie, container/cockpit-owner@fedoraproject.org is fixed to be container-cockpit-owner@fedoraproject.org).

We also need to change the fedora account system side to actually make those mailing list aliases, but thats out of scope for this ticket. This ticket is just fixing the git side/mailing-list setting.

Just a note that the test-* namespaces are being dropped :)

If we are concerned about the docker/ we could either escape it with \ or do - as suggested in the next comment. I am willing to work on this I would just need to know what to edit and where I can find it. @pingou @kevin

While debugging something else I found out that we have something broken in our mailing/hook set-up:
[hooks]
mailinglist = docker/cockpit-owner@fedoraproject.org,scm-commits@lists.fedoraproject.org

I'm pretty sure the docker/ will break the notification :)

I assume a translate of '/' on the git hooks.mailinglist is enough here. Please review attached patch.

Submitted PR to github/dist-git here - https://github.com/release-engineering/dist-git/pull/15

Okay, this PR has been merged upstream in dist-git. What's the process to get this packaged/deployed?

Also, it looks like roles/distgit/files/setup_git_package is no longer used and may be deleted/removed to prevent confusion. Attaching git-format-patch for that change.

I will be releasing new dist-git version today.

Example of how it works now:

$ setup_git_package foobar/foo
Done.

Later in git dir:

clime@coprbox /var/lib/dist-git/git/foobar/foo.git $ grep -r fedoraproject.org *                                                                                                               
config: mailinglist = foobar-foo-owner@fedoraproject.org,scm-commits@lists.fedoraproject.org
config: maildomain = fedoraproject.org

In other words, it works correctly.

Thanks for the testing @clime. It looks like the copr/dist_git and distgit roles both push out state=latest on that package so I assume this update will be pushed downstream once ansible has been run.

This looks like something we can push out after the freeze is done with the F26 release. Thank you for the work on this.

Okay, this PR has been merged upstream in dist-git. What's the process to get this packaged/deployed?
Also, it looks like roles/distgit/files/setup_git_package is no longer used and may be deleted/removed to prevent confusion. Attaching git-format-patch for that change.

Hello, Brandon, it seem that the patch has different whitespaces at certain places than what are in the original (setup_git_package) file and I could not apply it hence. E.g. here at that line in the patch are only spaces:

 -h,--help                  This help message

But in the original file, there are tabs as well as spaces.

Can you, please, try to regenerate the patch? I am not sure where exactly this problem originates.

Sure thing. Let's try it again. Same name.

Applied.

ok. I think this is all done now?

Please let us know if there's anything more to apply here...