#273 Downloading file from a git based project is not working

Created 8 years ago by kushal

https://hosted.fedoraproject.org/projects/opyum/browser/system-install-yumpacks.py

From the above link if you try to download the file in the original format , trac is showing internal error.

Python Traceback Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 406, in dispatch_request dispatcher.dispatch(req) File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 237, in dispatch resp = chosen_handler.process_request(req) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 145, in process_request self._render_file(req, repos, node, rev) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 230, in _render_file req.send_header('Last-Modified', http_date(node.last_modified)) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 375, in <lambda> last_modified = property(lambda x: x.get_last_modified()) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 374, in get_last_modified raise NotImplementedError NotImplementedError

Hey kushal, This seems to be working now at the new address (and the old one though it will be going away soon) Can you verify?

https://fedorahosted.org/opyum/browser/system-install-yumpacks.py

It failed again :(

Tried to download in original format.

Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 406, in dispatch_request dispatcher.dispatch(req) File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 237, in dispatch resp = chosen_handler.process_request(req) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 145, in process_request self._render_file(req, repos, node, rev) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 230, in _render_file req.send_header('Last-Modified', http_date(node.last_modified)) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 375, in <lambda> last_modified = property(lambda x: x.get_last_modified()) File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 374, in get_last_modified raise NotImplementedError NotImplementedError

An example link would be https://fedorahosted.org/opyum/browser/system-install-yumpacks.py?format=txt, just to make it faster. I think it's yet another problem with the git plugin :(

Just found a new git plugin, with (hopefully) some active development. http://nanosleep.org/proj/trac-git-plugin

Jesse, do you think this other git plugin is worth looking at?

Replying to [comment:5 mmcgrath]:

Jesse, do you think this other git plugin is worth looking at?

Yes I do. In fact, I wonder if their changes can just be added as a patch to my original package. If not, we can just switch to their source release for the package. I'm a little busy this week, but I think the git-plugin package has cvsextras open for commit. Feel free to update/test the plugin.

I've pulled the patches from said site and added them to our package. Now the package is an svn snapshot with a snapshot of git patches applied. The morbid in me wants to call this package: trac-git-plugin-0.0.1-5.20070705svn1536.20080516git72c86153.el5 but I'll refrain from that.

trac-git-plugin-0.0.1-5.20070705svn1536.fc10 is http://koji.fedoraproject.org/koji/buildinfo?buildID=49403

and

trac-git-plugin-0.0.1-5.20070705svn1536.el5 is http://buildsys.fedoraproject.org/build-status/job.psp?uid=39016

We should pick a time to install this on hosted1 and run through some of our known current pain points and other validation to make sure things still work and have been improved.

Turns out that this plugin update doesn't fix file downloads. Quite simply the code to do the downloads is just not there. More significant work would need to be done, something that I'm not able to do right now.

I just checked the links in this ticket and they all seemed to be working right. I'll go ahead and close this ticket as fixed. if I'm missing something please re-open it.

Login to comment on this ticket.