PR#232: Make core Plasma (KDE) packages mandatory - fedora-comps

fedora-comps

#232 Make core Plasma (KDE) packages mandatory

Merged 6 years ago by ausil. Opened 6 years ago by adamwill.

adamwill/fedora-comps kde-mandatory into master

Make core Plasma (KDE) packages mandatory

Adam Williamson • 6 years ago

774123b

comps-f29.xml.in

file modified

+6 -6

		`@@ -3594,7 +3594,7 @@`
		`<packagereq>phonon-qt5-backend-gstreamer</packagereq>`
		`<packagereq>pinentry-qt</packagereq>`
		`<packagereq>plasma-breeze</packagereq>`
		`- <packagereq>plasma-desktop</packagereq>`
		`+ <packagereq type="mandatory">plasma-desktop</packagereq>`
		`<packagereq>plasma-desktop-doc</packagereq>`
		`<packagereq>plasma-discover</packagereq>`
		`<packagereq>plasma-drkonqi</packagereq>`
		`@@ -3608,14 +3608,14 @@`
		`<packagereq>plasma-pa</packagereq>`
		`<packagereq>plasma-pk-updates</packagereq>`
		`<packagereq>plasma-user-manager</packagereq>`
		`- <packagereq>plasma-workspace</packagereq>`
		`+ <packagereq type="mandatory">plasma-workspace</packagereq>`
		`<packagereq>plasma-workspace-geolocation</packagereq>`
		`<packagereq>polkit-kde</packagereq>`
		`- <packagereq>qt5-qtbase-gui</packagereq>`
		`+ <packagereq type="mandatory">qt5-qtbase-gui</packagereq>`
		`<packagereq>qt5-qtdeclarative</packagereq>`
		`- <packagereq>sddm</packagereq>`
		`- <packagereq>sddm-breeze</packagereq>`
		`- <packagereq>sddm-kcm</packagereq>`
		`+ <packagereq type="mandatory">sddm</packagereq>`
		`+ <packagereq type="mandatory">sddm-breeze</packagereq>`
		`+ <packagereq type="mandatory">sddm-kcm</packagereq>`
		`<packagereq>sni-qt</packagereq>`
		`<packagereq>spectacle</packagereq>`
		`<packagereq>xorg-x11-drv-libinput</packagereq>`

adamwill commented 6 years ago

This makes core Plasma desktop packages mandatory. That means
the group they are in (kde-desktop) will not be considered to be
'installed' if they are removed, and importantly, image composes
will fail (as opposed to 'succeeding', but with the packages left
out) if they are missing or not installable. That's the main
benefit here.

Amendments to the list welcome, this was just my best guess at
what constitutes the really core packages.

Signed-off-by: Adam Williamson awilliam@redhat.com

adamwill commented 6 years ago

@kkofler @rdieter

adamwill commented 6 years ago

Note, this is part of my efforts to address https://bugzilla.redhat.com/show_bug.cgi?id=1427365 , which has been kinda a long-standing thing: dnf changed the way image composes work, yum would fail if a mandatory or default package was available but not installable, dnf does this for mandatory packages (now) but not default ones, those it just silently leaves it out of the transaction. I'm also working with anaconda devs to at least log when this happens, but I think it also makes sense to make really key packages mandatory.

rdieter commented 6 years ago

Good idea +1

I'm torn whether to include sddm in the list,

rebased onto 774123b

6 years ago

kkofler commented 6 years ago

"Mandatory" used to be the default if nothing is specified. Does it now default to "default"? Or to some undocumented intermediate state? I still think it would be a good idea to explicitly mark the other packages (i.e. all those you did not mark mandatory) as type="default". See also #204.

kkofler commented 6 years ago

(Historically, type="default" did not mean "the default type", but "installed by default".)

ausil commented 6 years ago

Historically mandatory default and optional only had effect in anaconda, mandatory you were forced to have installed, default was selected by default but you could choose to unselect, optional was unselected by default but you could select.

ausil commented 6 years ago

Commit 99fa047 fixes this pull-request