#97 sidebar items center aligned and form tag moved
Merged 6 months ago by jflory7. Opened 6 months ago by phoenixabhishek.

form tag commit added
PhoeniXAbhisheK • 6 months ago  
sidebar items center aligned
PhoeniXAbhisheK • 6 months ago  
file modified
+2

@@ -114,6 +114,8 @@

          width: 25%;

          height: calc(100% + 20px);

          position: fixed;

+         display: flex;

+         justify-content: center;

          background: -moz-linear-gradient(top,  #3c6eb4 0%, #3c6eb4 27%, #3c6eb4 27%, #3c6eb4 100%);

          background: -webkit-linear-gradient(top,  #3c6eb4 0%, #3c6eb4 27%, #3c6eb4 27%, #3c6eb4 100%);

          background: linear-gradient(to bottom,  #3c6eb4 0%, #3c6eb4 27%, #3c6eb4 27%, #3c6eb4 100%);

file modified
+3 -3

@@ -37,7 +37,8 @@

                  <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">FAQ</a></li>

                  {% url 'messaging:archive' as url %}

                  <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">Happiness Archive</a></li>

-                 {% if user.is_authenticated %}

+             </ul>

+             {% if user.is_authenticated %}

                  <form id="logout" action="{% url 'oidc_logout' %}" method="post">

                      {% csrf_token %}

                      <button type="submit" class="btn btn-logout">

@@ -52,8 +53,7 @@

                      <span>&nbsp;Login</span>

                      </button>

                  </form>

-                 {% endif %}

-             </ul>

+             {% endif %}

          </div>

      </aside>

      <main>

Solving issue #74 : center-aligned the contents of sidebar
The changes can be seen here

Also,
The form tag used for login/logout in the sidebar was placed inside the 'ul' element but was not a child 'li' element.
Hence removed outside for better HTML semantics.
Those changes can be viewed here

1 new commit added

  • form tag commit added
6 months ago

Metadata Update from @jflory7:
- Pull-request tagged with: difficulty - easy, good first issue, type - frontend

6 months ago

Hi @phoenixabhishek, this change is simple to me. It looks like we have to break from the upstream project since we have different design assets. I think that's okay in this case.

Merging! :clapper:

Pull-Request has been merged by jflory7

6 months ago

Hi @jflory7 thaks for the merge.
Also, should I make a PR to the upstream (mxsasha/happinesspackets) too for this?

@phoenixabhishek This was a minor change we needed to make since our Fedora-specific logo scaled differently on mobile devices. Since it's only cosmetic, I don't think this change needs to be sent upstream.

Ok, thanks :smile:
Can you assign me another issue I can work on please.