#95 Remove style tag so as to stop rendering in browser.
Merged 5 years ago by jflory7. Opened 5 years ago by alishapapun.
fedora-commops/ alishapapun/fedora-happiness-packets style-remove  into  master

file modified
+9 -1
@@ -182,7 +182,7 @@ 

      display: inline-block;

      vertical-align: top;

      font: normal normal normal 11px/18px 'Helvetica Neue',Arial,sans-serif;

-     font-size: 13px;

+     font-size: 0.6em;

      line-height: 26px;

      border-radius: 4px;

  }
@@ -206,3 +206,11 @@ 

          font-size: 15px;

      }

  }

+ 

+ .twitter {

+     background-color: #00aced;

+ }

+ 

+ .twitter:hover {

+     background-color: #0084b4;

+ } 

\ No newline at end of file

file modified
-14
@@ -1,17 +1,3 @@ 

- <style type="text/css">

- 	.sharebutton {

- 		font-size: 0.6em;

- 	}

- 

- 	.twitter {

- 		background-color: #00aced;

- 	}

- 

- 	.twitter:hover {

- 		background-color: #0084b4;

- 	}

- </style>

- 

  <div class="row">

  	<a class="g-interactivepost sharebutton google" data-contenturl="https://happinesspackets.fedorainfracloud.org/" data-clientid="427442962349-biuc5ks65luss5h3v5oqtj15jigaqoib.apps.googleusercontent.com" data-cookiepolicy="single_host_origin" data-prefilltext="#WeAreFedora" data-calltoactionurl="http://plus.google.com/pages/create"><i class="fab fa-google-plus-g fa-lg"></i> Share #WeAreFedora</a>

  	<script type="text/javascript">(function() {var po = document.createElement('script'); po.type = 'text/javascript'; po.async = true; po.src = 'https://apis.google.com/js/client:plusone.js'; var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(po, s);})();</script>

no initial comment

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, needs info, type - frontend

5 years ago

Hi @alishapapun, thanks for the pull request. A few comments:

  1. Is this pull request addressing an issue? If so, what issue are you addressing?
  2. Could you please upload a screenshot of what this change looks like? It makes reviewing this pull request easier.

Hi @alishapapun, thanks for the pull request. A few comments:

Is this pull request addressing an issue? If so, what issue are you addressing?
Could you please upload a screenshot of what this change looks like? It makes reviewing this pull request easier.

Proper insight is represented through screenshots in issue #94 (https://pagure.io/fedora-commops/fedora-happiness-packets/issue/94)

@alishapapun Thanks, I understand this change now. Thanks for the improvement here! Merging. :clapper:

This will also close #94.

Pull-Request has been merged by jflory7

5 years ago