#75 adds sample messages to home page
Closed 5 years ago by jflory7. Opened 5 years ago by kritisingh1.
fedora-commops/ kritisingh1/fedora-happiness-packets sample-message  into  master

@@ -45,7 +45,31 @@ 

          As an example, here are two random messages from our archive:

      </p>

  

-     {% include 'messaging/_message_list.html' %}

+    <h4>This message was sent to the Django: Under the Hood team</h4>

+     <blockquote>

+         <p>

+             I feel totally overwhelmed, surprised and very, very grateful. Thank you for caring. You are unbelievable.

+             You are a bunch of craziest, the most positive people I've met. You inspire me to give back to community

+             even more. I wish I could express properly what I'm feeling right now...

+         </p>

+ 

+         <p>

+             May it always rain stroopwafels on you. But not all the time, that could be inconvenient. Only when you

+             feel like having stroopwafels. Or someone that you like feels like having stroopwafels. Or you just want

+             to make it rain stroopwafels.

+         </p>

+ 

+         <p>

+             Sending hugs, you crazy, amazing people!

+         </p>

+     </blockquote>

+ 

+     <h4>Another contributed message</h4>

+     <blockquote>

+         Thank you for writing such a great article. I’ve seen some of your other writing and ideas and you seem

+         to capture difficult concepts very well. I’m really happy that you’re part of our community, and aspire

+         to be as great in some of these things as you are some day :)

+     </blockquote>

  

      <p class="text-center">

          <a class="btn btn-primary btn-lg btn-responsive" href="{% url 'messaging:send' %}" role="button">Send some happiness now! <img class="emoji" src="static/images/emoji/loveletter.png" alt="💌" title="Love letter" aria-label="Emoji: Love letter"></a>

Closes issue #69
@jonatoni please review. Thanks :)

@kritisingh1 did you just add a static sample message ?

Yes. There are a couple of reasons to do so.
Those are sample messages and not archives, and are therefore meant to give the user a first hand glance of what are happiness packets actually. So there is no point of retrieving it from backend and presenting.
Also, if we retrieve it from backend where the archives are stored, there might be entries which aren't so meaningful . We don't want to present spam data to the user on home page.
I hope that helped :)

@kritisingh1 The better approach to #69 is to figure out why the macro doesn't work in our environment. By making this static, we also move further away from the upstream project. It's important to keep to what upstream does so it is easier to pull in new changes if needed in the future.

I am cancelling this pull request, but check out my comment here for an idea on a next step to explore this issue.

Metadata Update from @jflory7:
- Pull-request tagged with: type - frontend, type - summer coding
- Request assigned

5 years ago

Pull-Request has been closed by jflory7

5 years ago