#67 Implement highlight current page in navigation
Closed 5 years ago by jflory7. Opened 5 years ago by b17059.
fedora-commops/ b17059/fedora-happiness-packets issue_50_fix  into  master

file modified
+5 -5
@@ -28,15 +28,15 @@ 

              <ul class="nav nav-stacked">

                  <li><a>Packets sent: <b>{{ packets_sent }}</b></a></li>

                  {% url 'messaging:send' as url %}

-                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">Send some happiness!</a></li>

+                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">{% ifequal request.path url %}<b><u>{% endifequal %}Send some happiness!{% ifequal request.path url %}</b></u>{% endifequal %}</a></li>

                  {% url 'messaging:start' as url %}

-                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">What are Happiness Packets?</a></li>

+                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">{% ifequal request.path url %}<b><u>{% endifequal %}What are Happiness Packets?{% ifequal request.path url %}</b></u>{% endifequal %}</a></li>

                  {% url 'messaging:inspiration' as url %}

-                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">Get inspired</a></li>

+                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">{% ifequal request.path url %}<b><u>{% endifequal %}Get inspired{% ifequal request.path url %}</b></u>{% endifequal %}</a></li>

                  {% url 'messaging:faq' as url %}

-                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">FAQ</a></li>

+                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">{% ifequal request.path url %}<b><u>{% endifequal %}FAQ{% ifequal request.path url %}</b></u>{% endifequal %}</a></li>

                  {% url 'messaging:archive' as url %}

-                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">Happiness Archive</a></li>

+                 <li role="presentation" {% if url in request.path %}class="active"{% endif %}><a href="{{ url }}">{% ifequal request.path url %}<b><u>{% endifequal %}Happiness Archive{% ifequal request.path url %}</b></u>{% endifequal %}</a></li>

                  {% if user.is_authenticated %}

                  <form id="logout" action="{% url 'oidc_logout' %}" method="post">

                      {% csrf_token %}

Fixes Issue #50 . It makes the active page link text bold and underlined in the navigation menu.

Hi, I followed up with more detail in #50. We should support the change upstream to implement it here. Our fork should focus on Fedora-specific changes only, as much as possible. If upstream accepts the change, we will apply the patch downstream.

Pull-Request has been closed by jflory7

5 years ago
Metadata