PR#58: Fix import error that appeared when trying to run celery - fedora-commops/fedora-happiness-packets

fedora-commops / fedora-happiness-packets

#58 Fix import error that appeared when trying to run celery

Closed 5 years ago by jflory7. Opened 5 years ago by echoduck.

fedora-commops/ echoduck/fedora-happiness-packets celery_bugfix into master

Fix import error that appeared when trying to run celery

echoduck • 5 years ago

0c089f1

happinesspackets/__init__.py

file modified

-1

		`@@ -5,5 +5,4 @@`
		`from happinesspackets._celery import app as celery_app`

		`__all__ = ('celery_app',)`
		`-`
		`__author__ = 'erik'`

happinesspackets/settings/base.py

file modified

+1 -1

		`@@ -189,7 +189,7 @@`

		`REDIS_HOST = 'localhost'`
		`REDIS_PORT = '6379'`
		`- BROKER_URL = 'redis://' + REDIS_HOST + ':' + REDIS_PORT + '/0'`
		`+ CELERY_BROKER_URL = 'redis://' + REDIS_HOST + ':' + REDIS_PORT + '/0'`
		`BROKER_TRANSPORT_OPTIONS = {'visibility_timeout': 3600}`
		`CELERY_RESULT_BACKEND = 'redis://' + REDIS_HOST + ':' + REDIS_PORT + '/0'`

echoduck commented 5 years ago

Fixes an import error that is thrown when attempting to run celery using celery -A happinesspackets -l info, restoring the ability to send emails using Celery 4.2.1

echoduck commented 5 years ago

#59 has part of this PR implemented, but does not make changes to base.py.

Edited 5 years ago by echoduck

Pull-Request has been closed by echoduck

5 years ago

Pull-Request has been reopened by echoduck

5 years ago

rebased onto 45291fca808f183519b3d9998b412509f578d10a

5 years ago

rebased onto f9c079b8dcc9302ffad4902d5a91c646f7f2510e

5 years ago

rebased onto 0c089f1

5 years ago

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, needs testing, type - backend

5 years ago

jflory7 commented 5 years ago

@echoduck Thanks for this bug fix. I tested this change locally and verified it. Merging! :clapper:

Thanks for being patient with this pull request.

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Request assigned

5 years ago

jflory7 commented 5 years ago

@echoduck's patch is applied in commit bc96d40. Again I don't know why this pull request didn't close automatically. :question: :question: I'm canceling the PR, but this was actually accepted.

Pull-Request has been closed by jflory7

5 years ago